Re: [PATCH 11/14] staging: unisys: remove do{} while(0) in macros in channel.h

2014-08-06 Thread Dan Carpenter
On Wed, Aug 06, 2014 at 08:08:11AM -0500, Romer, Benjamin M wrote: > On Wed, 2014-08-06 at 11:18 +0300, Dan Carpenter wrote: > > On Tue, Aug 05, 2014 at 02:57:55PM -0400, Benjamin Romer wrote: > > > The CHANNEL_*_MISMATCH error message macros should not be inside of do > > > blocks. > > > > > >

Re: [PATCH 11/14] staging: unisys: remove do{} while(0) in macros in channel.h

2014-08-06 Thread Romer, Benjamin M
On Wed, 2014-08-06 at 11:18 +0300, Dan Carpenter wrote: > On Tue, Aug 05, 2014 at 02:57:55PM -0400, Benjamin Romer wrote: > > The CHANNEL_*_MISMATCH error message macros should not be inside of do > > blocks. > > > > Why not? We do that so they can be called like a function. These seem > to no

Re: [PATCH 11/14] staging: unisys: remove do{} while(0) in macros in channel.h

2014-08-06 Thread Dan Carpenter
On Tue, Aug 05, 2014 at 02:57:55PM -0400, Benjamin Romer wrote: > The CHANNEL_*_MISMATCH error message macros should not be inside of do blocks. > Why not? We do that so they can be called like a function. These seem to not be called at all. Just delete them (in a later patch). regards, dan

[PATCH 11/14] staging: unisys: remove do{} while(0) in macros in channel.h

2014-08-05 Thread Benjamin Romer
The CHANNEL_*_MISMATCH error message macros should not be inside of do blocks. Signed-off-by: Benjamin Romer --- .../staging/unisys/common-spar/include/channels/channel.h| 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/unisys/common-spar/includ