Re: [PATCH 10/12] staging: ks7010: fix checkpatch memset warning

2017-03-14 Thread Dan Carpenter
On Tue, Mar 14, 2017 at 09:44:07PM +1100, Tobin C. Harding wrote: > On Tue, Mar 14, 2017 at 12:27:07PM +0300, Dan Carpenter wrote: > > This code is #ifdeffed out so you should just delete it instead of > > fixing it. > > The TODO file specifically asks for ifdeffed code not to be removed unless >

Re: [PATCH 10/12] staging: ks7010: fix checkpatch memset warning

2017-03-14 Thread Tobin C. Harding
On Tue, Mar 14, 2017 at 12:27:07PM +0300, Dan Carpenter wrote: > This code is #ifdeffed out so you should just delete it instead of > fixing it. The TODO file specifically asks for ifdeffed code not to be removed unless one knows exactly what is going on. I hope to get to that level but am not the

Re: [PATCH 10/12] staging: ks7010: fix checkpatch memset warning

2017-03-14 Thread Dan Carpenter
This code is #ifdeffed out so you should just delete it instead of fixing it. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 10/12] staging: ks7010: fix checkpatch memset warning

2017-03-13 Thread Tobin C. Harding
Checkpatch emits WARNING: single byte memset is suspicious. Swapped 2nd/3rd argument? Call site in question is correct but is an unusual use of memset() to zero a single byte. The same can be achieved by assigning 0 directly to the memory location. Dereference pointer and assign 0 to that memory l