Re: [PATCH 1/7] staging:iio:ade7854: Rework I2C write function

2018-03-15 Thread Rodrigo Siqueira
Hi, I will fixes all of these things here and in the other patches and send a v2. Thanks for the review. On 03/15, Dan Carpenter wrote: > On Wed, Mar 14, 2018 at 03:10:18PM -0300, Rodrigo Siqueira wrote: > > The write operation using I2C has many code duplications and four > > different interfac

Re: [PATCH 1/7] staging:iio:ade7854: Rework I2C write function

2018-03-15 Thread Dan Carpenter
On Wed, Mar 14, 2018 at 03:10:18PM -0300, Rodrigo Siqueira wrote: > The write operation using I2C has many code duplications and four > different interfaces per data size. This patch introduces a single > function that centralizes the main tasks. > > The central function inserted by this patch can

[PATCH 1/7] staging:iio:ade7854: Rework I2C write function

2018-03-14 Thread Rodrigo Siqueira
The write operation using I2C has many code duplications and four different interfaces per data size. This patch introduces a single function that centralizes the main tasks. The central function inserted by this patch can easily replace all the four functions related to the data size. However, th