Re: [PATCH 1/6 v3] staging: unisys: move installer to sysfs and split fields

2014-07-25 Thread Romer, Benjamin M
On Fri, 2014-07-25 at 14:05 +0300, Dan Carpenter wrote: > visorchannel_write() returns either 0 or -EFAULT so this condition is > never true. This bug occurs in several places. Thank you for catching my mistake. I'll fix this and change visorchannel_write() to return -EIO as you suggested. > Lo

Re: [PATCH 1/6 v3] staging: unisys: move installer to sysfs and split fields

2014-07-25 Thread Dan Carpenter
On Thu, Jul 24, 2014 at 02:08:42PM -0400, Benjamin Romer wrote: > +static ssize_t error_store(struct device *dev, struct device_attribute *attr, > + const char *buf, size_t count) > +{ > + u32 error; > + > + if (sscanf(buf, "%i\n", &error) == 1) { > + if (visorchanne

[PATCH 1/6 v3] staging: unisys: move installer to sysfs and split fields

2014-07-24 Thread Benjamin Romer
The installer entry in /proc/visorchipset/installer was composed of three separate fields as one entry. This patch removes the proc entry and associated functions, and creates new fields with distinct entries under sysfs in the visorchipset/install directory. The fields are: textid: used t