Re: [lustre-devel] [PATCH 1/3] staging:lustre: remove tcpip abstraction from libcfs

2015-05-22 Thread Greg Kroah-Hartman
On Fri, May 22, 2015 at 03:08:44PM +, Simmons, James A. wrote: > >This patch does a lot of stuff all at once and it is hard to review. It > >could easily be broken into patches which are easy to review. > > I have more very large patches. With breaking them up that means you are > going to se

Re: [lustre-devel] [PATCH 1/3] staging:lustre: remove tcpip abstraction from libcfs

2015-05-22 Thread Dan Carpenter
On Fri, May 22, 2015 at 03:08:44PM +, Simmons, James A. wrote: > >This patch does a lot of stuff all at once and it is hard to review. It > >could easily be broken into patches which are easy to review. > > I have more very large patches. With breaking them up that means you are > going to se

RE: [lustre-devel] [PATCH 1/3] staging:lustre: remove tcpip abstraction from libcfs

2015-05-22 Thread Simmons, James A.
>This patch does a lot of stuff all at once and it is hard to review. It >could easily be broken into patches which are easy to review. I have more very large patches. With breaking them up that means you are going to see hundreds of patches coming from me. >Ok in this next section we move func

Re: [PATCH 1/3] staging:lustre: remove tcpip abstraction from libcfs

2015-05-22 Thread Dan Carpenter
This patch does a lot of stuff all at once and it is hard to review. It could easily be broken into patches which are easy to review. > @@ -1378,15 +1378,15 @@ ksocknal_create_conn(lnet_ni_t *ni, ksock_route_t > *route, > ksocknal_txlist_done(ni, &zombies, 1); > ksocknal_peer_decref(

[PATCH 1/3] staging:lustre: remove tcpip abstraction from libcfs

2015-05-21 Thread James Simmons
From: James Simmons Since libcfs no longer builds for user land we can move the TCPIP abstraction that exist to the LNET layer which is the only place that uses it. Also the migrated code will use native linux kernel APIs directly instead of with wrappers. Signed-off-by: James Simmons Intel-bug