Re: [PATCH 1/3] Staging: qlge: Rename prefix of a function to qlge

2019-10-25 Thread Dan Carpenter
On Fri, Oct 25, 2019 at 05:28:42PM +0300, Samuil Ivanov wrote: > Dan you are correct it is a bit of a hodge podge :) > I think that it is better to have a bigger patches that will rename > more functions, but I don't this it is good to have all the > functions renamed in one patch. > > Just in the

Re: [PATCH 1/3] Staging: qlge: Rename prefix of a function to qlge

2019-10-25 Thread Samuil Ivanov
On Fri, Oct 25, 2019 at 01:19:05PM +0300, Dan Carpenter wrote: > On Fri, Oct 25, 2019 at 12:29:39AM +0300, Samuil Ivanov wrote: > > diff --git a/drivers/staging/qlge/qlge.h b/drivers/staging/qlge/qlge.h > > index 6ec7e3ce3863..e9f1363c5bf2 100644 > > --- a/drivers/staging/qlge/qlge.h > > +++ b/driv

Re: [PATCH 1/3] Staging: qlge: Rename prefix of a function to qlge

2019-10-25 Thread Dan Carpenter
On Fri, Oct 25, 2019 at 12:29:39AM +0300, Samuil Ivanov wrote: > diff --git a/drivers/staging/qlge/qlge.h b/drivers/staging/qlge/qlge.h > index 6ec7e3ce3863..e9f1363c5bf2 100644 > --- a/drivers/staging/qlge/qlge.h > +++ b/drivers/staging/qlge/qlge.h > @@ -2262,7 +2262,7 @@ int ql_write_mpi_reg(stru

[PATCH 1/3] Staging: qlge: Rename prefix of a function to qlge

2019-10-24 Thread Samuil Ivanov
This is from the TODO list: In terms of namespace, the driver uses either qlge_, ql_ (used by other qlogic drivers, with clashes, ex: ql_sem_spinlock) or nothing (with clashes, ex: struct ob_mac_iocb_req). Rename everything to use the "qlge_" prefix Function ql_soft_reset_mpi_risc renamed to qlge_