Re: [PATCH 1/2] staging: rtl8192u: Refactoring setKey function

2020-04-14 Thread Joe Perches
On Tue, 2020-04-14 at 22:18 -0300, Camylla Cantanheide wrote: > Em ter., 14 de abr. de 2020 às 09:35, Dan Carpenter < > dan.carpen...@oracle.com> escreveu: [] > > > diff --git a/drivers/staging/rtl8192u/r8192U_core.c [] > > > + target_content = macaddr[0] << 16 | > > > + ma

Re: [PATCH 1/2] staging: rtl8192u: Refactoring setKey function

2020-04-14 Thread Dan Carpenter
On Tue, Apr 14, 2020 at 09:01:18AM -0700, Joe Perches wrote: > On Tue, 2020-04-14 at 15:33 +0300, Dan Carpenter wrote: > > On Mon, Apr 13, 2020 at 03:01:28AM +, Camylla Goncalves Cantanheide > > wrote: > > > + > > > + for (i = 2; i < CAM_CONTENT_COUNT; i++) { > > > + write_nic_dword(de

Re: [PATCH 1/2] staging: rtl8192u: Refactoring setKey function

2020-04-14 Thread Joe Perches
On Tue, 2020-04-14 at 15:33 +0300, Dan Carpenter wrote: > On Mon, Apr 13, 2020 at 03:01:28AM +, Camylla Goncalves Cantanheide wrote: > > Changes of the local variable value and > > modification in the seletive repetition structure. > > > > This changelog isn't totally clear why you're doing t

Re: [PATCH 1/2] staging: rtl8192u: Refactoring setKey function

2020-04-14 Thread Dan Carpenter
On Mon, Apr 13, 2020 at 03:01:28AM +, Camylla Goncalves Cantanheide wrote: > Changes of the local variable value and > modification in the seletive repetition structure. > This changelog isn't totally clear why you're doing this. Just say: "I am refactorying setKey() to make it more clear.

Re: [PATCH 1/2] staging: rtl8192u: Refactoring setKey function

2020-04-13 Thread Joe Perches
On Mon, 2020-04-13 at 14:50 +0200, Greg KH wrote: > On Mon, Apr 13, 2020 at 03:01:28AM +, Camylla Goncalves Cantanheide wrote: > > Changes of the local variable value and > > modification in the seletive repetition structure. [] > > diff --git a/drivers/staging/rtl8192u/r8192U_core.c > > b/dri

Re: [PATCH 1/2] staging: rtl8192u: Refactoring setKey function

2020-04-13 Thread Greg KH
On Mon, Apr 13, 2020 at 03:01:28AM +, Camylla Goncalves Cantanheide wrote: > Changes of the local variable value and > modification in the seletive repetition structure. > > Signed-off-by: Camylla Goncalves Cantanheide > --- > drivers/staging/rtl8192u/r8192U_core.c | 52 -

[PATCH 1/2] staging: rtl8192u: Refactoring setKey function

2020-04-12 Thread Camylla Goncalves Cantanheide
Changes of the local variable value and modification in the seletive repetition structure. Signed-off-by: Camylla Goncalves Cantanheide --- drivers/staging/rtl8192u/r8192U_core.c | 52 -- 1 file changed, 24 insertions(+), 28 deletions(-) diff --git a/drivers/staging/rtl8