Re: [PATCH 1/2] staging: rtl8188eu: remove unnecessary asignment

2020-04-06 Thread Dan Carpenter
On Sun, Apr 05, 2020 at 01:22:29PM +0200, Michael Straube wrote: > Remove unnecessary asignment in SwLedBlink1(). The code path with the > asignment 'pLed->BlinkTimes = 0' is only executed when > 'pLed->BlinkTimes' is already zero and the value is not changed between > the test 'if (pLed->BlinkTime

Re: [PATCH 1/2] staging: rtl8188eu: remove unnecessary asignment

2020-04-06 Thread Dan Carpenter
On Mon, Apr 06, 2020 at 02:25:20PM +0300, Dan Carpenter wrote: > On Sun, Apr 05, 2020 at 01:22:29PM +0200, Michael Straube wrote: > > Remove unnecessary asignment in SwLedBlink1(). The code path with the > > asignment 'pLed->BlinkTimes = 0' is only executed when > > 'pLed->BlinkTimes' is already ze

[PATCH 1/2] staging: rtl8188eu: remove unnecessary asignment

2020-04-05 Thread Michael Straube
Remove unnecessary asignment in SwLedBlink1(). The code path with the asignment 'pLed->BlinkTimes = 0' is only executed when 'pLed->BlinkTimes' is already zero and the value is not changed between the test 'if (pLed->BlinkTimes == 0)' and the asignment. Signed-off-by: Michael Straube --- drivers