Re: [PATCH 1/2] staging: iio: ad7606: Move out of staging

2018-10-21 Thread Jonathan Cameron
On Thu, 18 Oct 2018 12:10:32 +0300 Stefan Popa wrote: > Move ad7606 ADC driver out of staging and into the mainline. > > Signed-off-by: Stefan Popa Hi Stefan, Great to be moving forward on this. A few comments inline. There are some somewhat old school structures in here we can do better no

Re: [PATCH 1/2] staging: iio: ad7606: Move out of staging

2018-10-18 Thread Dan Carpenter
On Thu, Oct 18, 2018 at 07:19:36PM +0200, Lars-Peter Clausen wrote: > On 10/18/2018 02:55 PM, Dan Carpenter wrote: > > On Thu, Oct 18, 2018 at 12:10:32PM +0300, Stefan Popa wrote: > >> +static int ad7606_read_samples(struct ad7606_state *st) > >> +{ > >> + unsigned int num = st->chip_info->num_cha

Re: [PATCH 1/2] staging: iio: ad7606: Move out of staging

2018-10-18 Thread Lars-Peter Clausen
On 10/18/2018 02:55 PM, Dan Carpenter wrote: > On Thu, Oct 18, 2018 at 12:10:32PM +0300, Stefan Popa wrote: >> +static int ad7606_read_samples(struct ad7606_state *st) >> +{ >> +unsigned int num = st->chip_info->num_channels; >> +u16 *data = st->data; >> +int ret; >> + >> +/* >> +

Re: [PATCH 1/2] staging: iio: ad7606: Move out of staging

2018-10-18 Thread Dan Carpenter
On Thu, Oct 18, 2018 at 12:10:32PM +0300, Stefan Popa wrote: > +static int ad7606_read_samples(struct ad7606_state *st) > +{ > + unsigned int num = st->chip_info->num_channels; > + u16 *data = st->data; > + int ret; > + > + /* > + * The frstdata signal is set to high while and

[PATCH 1/2] staging: iio: ad7606: Move out of staging

2018-10-18 Thread Stefan Popa
Move ad7606 ADC driver out of staging and into the mainline. Signed-off-by: Stefan Popa --- MAINTAINERS | 7 + drivers/iio/adc/Kconfig | 34 +++ drivers/iio/adc/Makefile | 3 + drivers/iio/adc/ad7606.c | 565 +