Hi,
On Fri, 2018-06-08 at 13:59 +0200, Linus Walleij wrote:
> Hi Sergio!
>
> Thanks for your patch!
>
> Given that we have combined pin control and GPIO drivers for
> almost all Mediatek chips in drivers/pinctrl/mediatek/*
> I would ideally like to have some input from the Mediatek
> maintainers
On Fri, Jun 8, 2018 at 2:17 PM, Linus Walleij wrote:
> A second thought:
Second thought is always a good thing :-)
>
> On Fri, Jun 8, 2018 at 1:59 PM, Linus Walleij
> wrote:
>
>>> + select GPIOLIB_IRQCHIP
>>
>> You are not using this so I guess remove that line.
> (...)
>>> +static int
>
On Fri, Jun 8, 2018 at 1:59 PM, Linus Walleij wrote:
> Hi Sergio!
>
> Thanks for your patch!
Hi Linus,
First of all, thanks for your feedback and effort reviewing this.
>
> On Sat, Jun 2, 2018 at 9:30 AM, Sergio Paracuellos
> wrote:
>
>> Add driver support for gpio of MT7621 SoC.
>>
>> Signed-
A second thought:
On Fri, Jun 8, 2018 at 1:59 PM, Linus Walleij wrote:
>> + select GPIOLIB_IRQCHIP
>
> You are not using this so I guess remove that line.
(...)
>> +static int
>> +mediatek_gpio_to_irq(struct gpio_chip *chip, unsigned int pin)
>> +{
>> + struct mtk_data *gpio_data = g
Hi Sergio!
Thanks for your patch!
Given that we have combined pin control and GPIO drivers for
almost all Mediatek chips in drivers/pinctrl/mediatek/*
I would ideally like to have some input from the Mediatek
maintainers (especially Sean Wang) on this, especially:
- Is MT7621 a non-pincontrol GP
Add driver support for gpio of MT7621 SoC.
Signed-off-by: Sergio Paracuellos
Reviewed-by: NeilBrown
---
drivers/gpio/Kconfig | 7 +
drivers/gpio/Makefile | 1 +
drivers/gpio/gpio-mt7621.c | 370 +
3 files changed, 378 insertions(+)
cre