Re: [PATCH 1/1] staging: unisys: Remove allocation from declaration line

2015-02-12 Thread Quentin Lambert
On 11/02/2015 11:23, Dan Carpenter wrote: On Wed, Feb 11, 2015 at 06:26:27AM +0800, Greg Kroah-Hartman wrote: On Tue, Feb 10, 2015 at 02:02:14PM +0100, Quentin Lambert wrote: This patch removes allocation from declaration line because people are known to gloss over declarations. Again, who are

Re: [PATCH 1/1] staging: unisys: Remove allocation from declaration line

2015-02-11 Thread Dan Carpenter
On Wed, Feb 11, 2015 at 06:26:27AM +0800, Greg Kroah-Hartman wrote: > On Tue, Feb 10, 2015 at 02:02:14PM +0100, Quentin Lambert wrote: > > This patch removes allocation from declaration line because > > people are known to gloss over declarations. > > Again, who are these lazy people, and why are

Re: [PATCH 1/1] staging: unisys: Remove allocation from declaration line

2015-02-10 Thread Greg Kroah-Hartman
On Tue, Feb 10, 2015 at 02:02:14PM +0100, Quentin Lambert wrote: > This patch removes allocation from declaration line because > people are known to gloss over declarations. Again, who are these lazy people, and why are they reading kernel code? Please, it's ok to allocate things in the declarati

Re: [PATCH 1/1] staging: unisys: Remove allocation from declaration line

2015-02-10 Thread Sudip Mukherjee
On Tue, Feb 10, 2015 at 02:02:14PM +0100, Quentin Lambert wrote: > This patch removes allocation from declaration line because > people are known to gloss over declarations. > > Signed-off-by: Quentin Lambert > --- > drivers/staging/unisys/visorchipset/visorchipset_main.c | 6 +++--- > drivers/s

[PATCH 1/1] staging: unisys: Remove allocation from declaration line

2015-02-10 Thread Quentin Lambert
This patch removes allocation from declaration line because people are known to gloss over declarations. Signed-off-by: Quentin Lambert --- drivers/staging/unisys/visorchipset/visorchipset_main.c | 6 +++--- drivers/staging/unisys/visorutil/charqueue.c| 3 ++- drivers/staging/unisys/