Re: [PATCH 1/1] staging: fix bcm/hostmibs.c checkpatch problems

2014-03-28 Thread Jake Edge
On Sun, 23 Mar 2014 10:45:09 -0700 Joe Perches wrote: > On Sat, 2014-03-22 at 09:50 -0600, Jake Edge wrote: > > Fix 4 checkpatch errors, many warnings in bcm/hostmibs.c > > Making code checkpatch clean shouldn't be the primary goal here. Perhaps not, but it was *my* goal :) > Removing uses of Hu

Re: [PATCH 1/1] staging: fix bcm/hostmibs.c checkpatch problems

2014-03-23 Thread Joe Perches
On Sat, 2014-03-22 at 09:50 -0600, Jake Edge wrote: > Fix 4 checkpatch errors, many warnings in bcm/hostmibs.c Making code checkpatch clean shouldn't be the primary goal here. Removing uses of Hungarian-style notation, CamelCase naming, and long variable names would be more helpful overall. > di

[PATCH 1/1] staging: fix bcm/hostmibs.c checkpatch problems

2014-03-22 Thread Jake Edge
From: Jake Edge Fix 4 checkpatch errors, many warnings in bcm/hostmibs.c Against next-20140321 tree Signed-off-by: Jake Edge --- There were two > 80 lines that I couldn't find a sensible way to split up, otherwise it is checkpatch clean diff --git a/drivers/staging/bcm/hostmibs.c b/drivers