Re: [PATCH 1/1] Drivers: scsi: storvsc: Add blist flags

2014-08-01 Thread Sitsofe Wheeler
On Thu, Jul 24, 2014 at 07:40:36AM +0200, Hannes Reinecke wrote: > On 07/22/2014 01:06 AM, K. Y. Srinivasan wrote: > >Add blist flags to permit the reading of the VPD pages even when > >the target may claim SPC-2 compliance. MSFT targets currently > >claim SPC-2 compliance while they implement post

Re: [PATCH 1/1] Drivers: scsi: storvsc: Add blist flags

2014-07-23 Thread Hannes Reinecke
On 07/22/2014 01:06 AM, K. Y. Srinivasan wrote: Add blist flags to permit the reading of the VPD pages even when the target may claim SPC-2 compliance. MSFT targets currently claim SPC-2 compliance while they implement post SPC-2 features. With this patch we can correctly handle WRITE_SAME_16 iss

Re: [PATCH 1/1] Drivers: scsi: storvsc: Add blist flags

2014-07-23 Thread Sitsofe Wheeler
On Wed, Jul 23, 2014 at 07:15:58AM -0700, Christoph Hellwig wrote: > On Wed, Jul 23, 2014 at 03:10:28PM +0100, Sitsofe Wheeler wrote: > > I'm not sure this alone will work - won't sdev_bflags/bflags have > > already been built at this point? > > They've been built up, but we can still or new value

RE: [PATCH 1/1] Drivers: scsi: storvsc: Add blist flags

2014-07-23 Thread KY Srinivasan
t; a...@canonical.com; jasow...@redhat.com; jbottom...@parallels.com; > linux-s...@vger.kernel.org > Subject: Re: [PATCH 1/1] Drivers: scsi: storvsc: Add blist flags > > On Wed, Jul 23, 2014 at 01:54:43PM +0100, Sitsofe Wheeler wrote: > > That's good to know (I was

RE: [PATCH 1/1] Drivers: scsi: storvsc: Add blist flags

2014-07-23 Thread KY Srinivasan
; jasow...@redhat.com; jbottom...@parallels.com; h...@infradead.org; > linux-s...@vger.kernel.org > Subject: Re: [PATCH 1/1] Drivers: scsi: storvsc: Add blist flags > > On Mon, Jul 21, 2014 at 04:06:01PM -0700, K. Y. Srinivasan wrote: > > Add blist flags to permit the reading of

Re: [PATCH 1/1] Drivers: scsi: storvsc: Add blist flags

2014-07-23 Thread Sitsofe Wheeler
On Wed, Jul 23, 2014 at 07:10:14AM -0700, Christoph Hellwig wrote: > On Wed, Jul 23, 2014 at 01:54:43PM +0100, Sitsofe Wheeler wrote: > > That's good to know (I was worried the device would not be detected as > > supporting discard because it doesn't report lbpme and doesn't declare a > > conforman

Re: [PATCH 1/1] Drivers: scsi: storvsc: Add blist flags

2014-07-23 Thread Christoph Hellwig
On Wed, Jul 23, 2014 at 03:10:28PM +0100, Sitsofe Wheeler wrote: > I'm not sure this alone will work - won't sdev_bflags/bflags have > already been built at this point? They've been built up, but we can still or new values into it. It looks fine to me from review, but if you can test it on an act

Re: [PATCH 1/1] Drivers: scsi: storvsc: Add blist flags

2014-07-23 Thread Sitsofe Wheeler
On Mon, Jul 21, 2014 at 04:06:01PM -0700, K. Y. Srinivasan wrote: > Add blist flags to permit the reading of the VPD pages even when > the target may claim SPC-2 compliance. MSFT targets currently > claim SPC-2 compliance while they implement post SPC-2 features. > With this patch we can correctly

Re: [PATCH 1/1] Drivers: scsi: storvsc: Add blist flags

2014-07-23 Thread Christoph Hellwig
On Wed, Jul 23, 2014 at 01:54:43PM +0100, Sitsofe Wheeler wrote: > That's good to know (I was worried the device would not be detected as > supporting discard because it doesn't report lbpme and doesn't declare a > conformance version (see below)). Ok, that makes things worse - you might be able t

Re: [PATCH 1/1] Drivers: scsi: storvsc: Add blist flags

2014-07-23 Thread Sitsofe Wheeler
On Wed, Jul 23, 2014 at 04:51:28AM -0700, Christoph Hellwig wrote: > On Wed, Jul 23, 2014 at 11:04:48AM +0100, Sitsofe Wheeler wrote: > > OK I've just seen this as I was about to post a similar patch to get > > discard going on Hyper-V. Will your patches handle Hyper-V pass through > > devices > >

Re: [PATCH 1/1] Drivers: scsi: storvsc: Add blist flags

2014-07-23 Thread Christoph Hellwig
On Wed, Jul 23, 2014 at 11:04:48AM +0100, Sitsofe Wheeler wrote: > OK I've just seen this as I was about to post a similar patch to get > discard going on Hyper-V. Will your patches handle Hyper-V pass through > devices > that support discard? The SSD I have here reports the following in the Linux

Re: [PATCH 1/1] Drivers: scsi: storvsc: Add blist flags

2014-07-23 Thread Sitsofe Wheeler
On Mon, Jul 21, 2014 at 04:06:01PM -0700, K. Y. Srinivasan wrote: > Add blist flags to permit the reading of the VPD pages even when > the target may claim SPC-2 compliance. MSFT targets currently > claim SPC-2 compliance while they implement post SPC-2 features. > With this patch we can correctly

[PATCH 1/1] Drivers: scsi: storvsc: Add blist flags

2014-07-21 Thread K. Y. Srinivasan
Add blist flags to permit the reading of the VPD pages even when the target may claim SPC-2 compliance. MSFT targets currently claim SPC-2 compliance while they implement post SPC-2 features. With this patch we can correctly handle WRITE_SAME_16 issues. Signed-off-by: K. Y. Srinivasan --- driver

RE: [PATCH 1/1] Drivers: scsi: storvsc: Add blist flags

2014-07-21 Thread KY Srinivasan
; jasow...@redhat.com; jbottom...@parallels.com; h...@infradead.org; > linux-s...@vger.kernel.org > Subject: Re: [PATCH 1/1] Drivers: scsi: storvsc: Add blist flags > > On Sun, Jul 20, 2014 at 08:33:42PM -0700, K. Y. Srinivasan wrote: > > Add blist flags to permit the reading of

Re: [PATCH 1/1] Drivers: scsi: storvsc: Add blist flags

2014-07-21 Thread Christoph Hellwig
On Sun, Jul 20, 2014 at 08:33:42PM -0700, K. Y. Srinivasan wrote: > Add blist flags to permit the reading of the VPD pages even when > the target may claim SPC-2 compliance. MSFT targets currently > claim SPC-2 compliance while they implement post SPC-2 features. > With this patch we can correctly

[PATCH 1/1] Drivers: scsi: storvsc: Add blist flags

2014-07-20 Thread K. Y. Srinivasan
Add blist flags to permit the reading of the VPD pages even when the target may claim SPC-2 compliance. MSFT targets currently claim SPC-2 compliance while they implement post SPC-2 features. With this patch we can correctly handle WRITE_SAME_16 issues. Signed-off-by: K. Y. Srinivasan --- driver