Re: [PATCH 07/19] staging: most: Remove unnecessary externs

2015-08-14 Thread Dan Carpenter
On Fri, Aug 14, 2015 at 10:36:35AM +0200, Andrey Shvetsov wrote: > On Mon, Aug 10, 2015 at 02:51:22PM -0700, Joe Perches wrote: > > Using 'extern' is not necessary for function prototypes. > > > We use them to mark dependency inversions (callbacks). > I thought about comments instead of, but I'm n

Re: [PATCH 07/19] staging: most: Remove unnecessary externs

2015-08-14 Thread Andrey Shvetsov
On Mon, Aug 10, 2015 at 02:51:22PM -0700, Joe Perches wrote: > Using 'extern' is not necessary for function prototypes. > We use them to mark dependency inversions (callbacks). I thought about comments instead of, but I'm not sure what is worse. -- Regards, Andrey ___

[PATCH 07/19] staging: most: Remove unnecessary externs

2015-08-10 Thread Joe Perches
Using 'extern' is not necessary for function prototypes. Signed-off-by: Joe Perches --- drivers/staging/most/hdm-dim2/dim2_hal.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/most/hdm-dim2/dim2_hal.h b/drivers/staging/most/hdm-dim2/dim2_hal.h index