Re: [PATCH 00/32] staging: wfx: rework the Tx queue

2020-04-03 Thread Dan Carpenter
I didn't quite finish reviewing these pathches last night. Looks good. You will need a check on "ssidlen" to prevent memory corruption, as discussed in patch 1, but that's not a bug which was introduced by this patchset. None of my other comments really applied to the patchset itself, just to the

[PATCH 00/32] staging: wfx: rework the Tx queue

2020-04-01 Thread Jerome Pouiller
From: Jérôme Pouiller This current implementation of the Tx queue is far more complex than necessary and its behavior is dubious on some corner cases. This series rework the Tx queue: - Simplify support for QoS (since device already do the job) - Simplify support for Power Saving stations (si