RE: [PATCH 00/28] staging: comedi: s626: tidy up

2013-10-09 Thread Hartley Sweeten
On Tuesday, October 08, 2013 11:06 AM, Ian Abbott wrote: > > Tidy up the s626 comedi driver a bit. This driver is mind numbingly hard to follow... All the subtracted bit shifting and masking is still a mess. Probably why the code is so comment happy. But, your cleanup does help so... Reviewed-by

[PATCH 00/28] staging: comedi: s626: tidy up

2013-10-08 Thread Ian Abbott
Tidy up the s626 comedi driver a bit. 01) staging: comedi: s626: tidy the header file a bit 02) staging: comedi: s626: tidy up comments at top of file 03) staging: comedi: s626: tidy up main source code file 04) staging: comedi: s626: convert a printk() 05) staging: comedi: s626: remove unused DMA