Re: [PATCH 00/25] line6usb cleanup

2015-01-12 Thread Takashi Iwai
At Mon, 12 Jan 2015 17:35:01 +0100, Takashi Iwai wrote: > > At Sun, 11 Jan 2015 15:04:55 -0600, > Chris Rorvick wrote: > > > > > At Fri, 9 Jan 2015 23:35:46 -0600, > > > Chris Rorvick wrote: > > >> > > >> I have a TonePort UX2 that I've used for testing, meaning that some of > > >> this is reall

Re: [PATCH 00/25] line6usb cleanup

2015-01-12 Thread Takashi Iwai
At Mon, 12 Jan 2015 11:52:27 -0800, Greg Kroah-Hartman wrote: > > On Mon, Jan 12, 2015 at 05:35:01PM +0100, Takashi Iwai wrote: > > At Sun, 11 Jan 2015 15:04:55 -0600, > > Chris Rorvick wrote: > > > > > > > At Fri, 9 Jan 2015 23:35:46 -0600, > > > > Chris Rorvick wrote: > > > >> > > > >> I have

Re: [PATCH 00/25] line6usb cleanup

2015-01-12 Thread Greg Kroah-Hartman
On Mon, Jan 12, 2015 at 05:35:01PM +0100, Takashi Iwai wrote: > At Sun, 11 Jan 2015 15:04:55 -0600, > Chris Rorvick wrote: > > > > > At Fri, 9 Jan 2015 23:35:46 -0600, > > > Chris Rorvick wrote: > > >> > > >> I have a TonePort UX2 that I've used for testing, meaning that some of > > >> this is re

Re: [PATCH 00/25] line6usb cleanup

2015-01-12 Thread Takashi Iwai
At Sun, 11 Jan 2015 15:04:55 -0600, Chris Rorvick wrote: > > > At Fri, 9 Jan 2015 23:35:46 -0600, > > Chris Rorvick wrote: > >> > >> I have a TonePort UX2 that I've used for testing, meaning that some of > >> this is really only compile-tested. > > > > If anyone is responsible for testing with re

Re: [PATCH 00/25] line6usb cleanup

2015-01-12 Thread Dan Carpenter
These patches look really nice. Thanks for doing this. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 00/25] line6usb cleanup

2015-01-11 Thread Chris Rorvick
> At Fri, 9 Jan 2015 23:35:46 -0600, > Chris Rorvick wrote: >> >> I have a TonePort UX2 that I've used for testing, meaning that some of >> this is really only compile-tested. > > If anyone is responsible for testing with real hardware, I'll happily > review. To be clear, the TonePort UX2 is real

Re: [PATCH 00/25] line6usb cleanup

2015-01-11 Thread Stefan Hajnoczi
On Sun, Jan 11, 2015 at 10:34 AM, Takashi Iwai wrote: > At Fri, 9 Jan 2015 23:35:46 -0600, > Chris Rorvick wrote: >> >> The line6usb driver references the device's idProduct and, in some >> cases, the interface number in a number of places to determine device- >> specific configuration values and

Re: [PATCH 00/25] line6usb cleanup

2015-01-11 Thread Takashi Iwai
At Fri, 9 Jan 2015 23:35:46 -0600, Chris Rorvick wrote: > > The line6usb driver references the device's idProduct and, in some > cases, the interface number in a number of places to determine device- > specific configuration values and to call device-specific functionality. > Rework code to lever

Re: [PATCH 00/25] line6usb cleanup

2015-01-10 Thread Stefan Hajnoczi
On Sat, Jan 10, 2015 at 5:35 AM, Chris Rorvick wrote: > The line6usb driver references the device's idProduct and, in some > cases, the interface number in a number of places to determine device- > specific configuration values and to call device-specific functionality. > Rework code to leverage t

[PATCH 00/25] line6usb cleanup

2015-01-09 Thread Chris Rorvick
The line6usb driver references the device's idProduct and, in some cases, the interface number in a number of places to determine device- specific configuration values and to call device-specific functionality. Rework code to leverage the device table matching more effectively. Consolidate configur