Re: [PATCH 0/9] staging: octeon: multi rx group (queue) support

2016-08-31 Thread Ed Swierk
On 8/31/16 14:20, Aaro Koskinen wrote: > On Wed, Aug 31, 2016 at 09:20:07AM -0700, Ed Swierk wrote: >> Here's my workaround: > > [...] > >> -static int cvm_oct_poll(struct oct_rx_group *rx_group, int budget) >> +static int cvm_oct_poll(int group, int budget) >> { >> const int coreid =

Re: [PATCH 0/9] staging: octeon: multi rx group (queue) support

2016-08-31 Thread Aaro Koskinen
Hi, On Wed, Aug 31, 2016 at 09:20:07AM -0700, Ed Swierk wrote: > I'm not using CONFIG_NET_POLL_CONTROLLER either; the problem is in the > normal cvm_oct_napi_poll() path. > > Here's my workaround: [...] > -static int cvm_oct_poll(struct oct_rx_group *rx_group, int budget) > +static int cvm_oct_

Re: [PATCH 0/9] staging: octeon: multi rx group (queue) support

2016-08-31 Thread David Daney
On 08/31/2016 08:06 AM, Aaro Koskinen wrote: Hi, On Tue, Aug 30, 2016 at 06:12:17PM -0700, Ed Swierk wrote: On Tue, Aug 30, 2016 at 11:47 AM, Aaro Koskinen wrote: This series implements multiple RX group support that should improve the networking performance on multi-core OCTEONs. Basically w

Re: [PATCH 0/9] staging: octeon: multi rx group (queue) support

2016-08-31 Thread Ed Swierk
Aaro Koskinen wrote: > Oops, looks like I tested without CONFIG_NET_POLL_CONTROLLER enabled > and that seems to be broken. Sorry. I'm not using CONFIG_NET_POLL_CONTROLLER either; the problem is in the normal cvm_oct_napi_poll() path. Here's my workaround: --- a/drivers/staging/octeon/ethernet-rx

Re: [PATCH 0/9] staging: octeon: multi rx group (queue) support

2016-08-31 Thread Aaro Koskinen
Hi, On Tue, Aug 30, 2016 at 06:12:17PM -0700, Ed Swierk wrote: > On Tue, Aug 30, 2016 at 11:47 AM, Aaro Koskinen wrote: > > This series implements multiple RX group support that should improve > > the networking performance on multi-core OCTEONs. Basically we register > > IRQ and NAPI for each gr

Re: [PATCH 0/9] staging: octeon: multi rx group (queue) support

2016-08-30 Thread Aaro Koskinen
Hi, On Tue, Aug 30, 2016 at 06:12:17PM -0700, Ed Swierk wrote: > On Tue, Aug 30, 2016 at 11:47 AM, Aaro Koskinen wrote: > > This series implements multiple RX group support that should improve > > the networking performance on multi-core OCTEONs. Basically we register > > IRQ and NAPI for each gr

Re: [PATCH 0/9] staging: octeon: multi rx group (queue) support

2016-08-30 Thread Ed Swierk
Hi Aaro, On Tue, Aug 30, 2016 at 11:47 AM, Aaro Koskinen wrote: > This series implements multiple RX group support that should improve > the networking performance on multi-core OCTEONs. Basically we register > IRQ and NAPI for each group, and ask the HW to select the group for > the incoming pac

[PATCH 0/9] staging: octeon: multi rx group (queue) support

2016-08-30 Thread Aaro Koskinen
Hi, This series implements multiple RX group support that should improve the networking performance on multi-core OCTEONs. Basically we register IRQ and NAPI for each group, and ask the HW to select the group for the incoming packets based on hash. Tested on EdgeRouter Lite with a simple forwardi