Re: [PATCH 0/8] staging: unisys: visorchipset proc fixes

2014-07-19 Thread Greg KH
On Sat, Jul 19, 2014 at 02:26:48PM -0400, Ben Romer wrote: > Greg KH wrote: > > > What happened to the idea of only creating the sysfs files _if_ it is > > needed? You are always creating these files, and then can return > > -ENODEV if the device really isn't there, that's not what you should do

Re: [PATCH 0/8] staging: unisys: visorchipset proc fixes

2014-07-19 Thread Ben Romer
Greg KH wrote: > What happened to the idea of only creating the sysfs files _if_ it is > needed? You are always creating these files, and then can return > -ENODEV if the device really isn't there, that's not what you should do > for a sysfs file. If the file is present, it should return data,

Re: [PATCH 0/8] staging: unisys: visorchipset proc fixes

2014-07-19 Thread Greg KH
On Sat, Jul 19, 2014 at 10:26:53AM -0400, Benjamin Romer wrote: > This patch set moves several interfaces in the visorchipset module from procfs > to sysfs, and removes the remaining proc interfaces from the module. It > includes > documentation for the new interfaces in Documentation/ABI, and som

[PATCH 0/8] staging: unisys: visorchipset proc fixes

2014-07-19 Thread Benjamin Romer
This patch set moves several interfaces in the visorchipset module from procfs to sysfs, and removes the remaining proc interfaces from the module. It includes documentation for the new interfaces in Documentation/ABI, and some code cleanup in the new sysfs handler functions. Benjamin Romer (8):