Re: [PATCH] zcache: fix "zcache=" kernel parameter

2013-07-24 Thread Greg KH
first one I got, from Michal, as that's the > > > original author here, not Piotr... > > > > > > confused, and really grumpy about the whole zcache mess... > > > > Just get the second one (from Piotr) as it is more complete (it fixes > > also problem with inv

Re: [PATCH] zcache: fix "zcache=" kernel parameter

2013-07-24 Thread Bartlomiej Zolnierkiewicz
; original author here, not Piotr... > > > > confused, and really grumpy about the whole zcache mess... > > Just get the second one (from Piotr) as it is more complete (it fixes > also problem with invalid data being given to "zcache=" option or chosen > compre

Re: [PATCH] zcache: fix "zcache=" kernel parameter

2013-07-24 Thread Bartlomiej Zolnierkiewicz
bout the whole zcache mess... Just get the second one (from Piotr) as it is more complete (it fixes also problem with invalid data being given to "zcache=" option or chosen compressor not being supported by Crypto API). I feel a bit sad that this newer patch makes Michal's one obsolet

Re: [PATCH] zcache: fix "zcache=" kernel parameter

2013-07-24 Thread Greg KH
On Wed, Jul 24, 2013 at 01:54:56PM +0200, Bartlomiej Zolnierkiewicz wrote: > > On Wednesday, July 24, 2013 01:41:57 PM Michal Hocko wrote: > > On Wed 24-07-13 12:32:32, Bartlomiej Zolnierkiewicz wrote: > > > > > > Hi, > > > > > > On Wednesday, July 24, 2013 12:04:41 PM Michal Hocko wrote: > > >

Re: [PATCH] zcache: fix "zcache=" kernel parameter

2013-07-24 Thread Greg KH
On Wed, Jul 24, 2013 at 01:54:56PM +0200, Bartlomiej Zolnierkiewicz wrote: > > On Wednesday, July 24, 2013 01:41:57 PM Michal Hocko wrote: > > On Wed 24-07-13 12:32:32, Bartlomiej Zolnierkiewicz wrote: > > > > > > Hi, > > > > > > On Wednesday, July 24, 2013 12:04:41 PM Michal Hocko wrote: > > >

Re: [PATCH] zcache: fix "zcache=" kernel parameter

2013-07-24 Thread Bartlomiej Zolnierkiewicz
On Wednesday, July 24, 2013 01:41:57 PM Michal Hocko wrote: > On Wed 24-07-13 12:32:32, Bartlomiej Zolnierkiewicz wrote: > > > > Hi, > > > > On Wednesday, July 24, 2013 12:04:41 PM Michal Hocko wrote: > > > On Wed 24-07-13 12:02:35, Michal Hocko wrote: > > > > I have posted a similar fix quite s

Re: Re: [PATCH] zcache: fix "zcache=" kernel parameter

2013-07-24 Thread Michal Hocko
On Wed 24-07-13 12:32:32, Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On Wednesday, July 24, 2013 12:04:41 PM Michal Hocko wrote: > > On Wed 24-07-13 12:02:35, Michal Hocko wrote: > > > I have posted a similar fix quite some time ago and I guess Greg should > > > already have it. > > > > For re

Re: Re: [PATCH] zcache: fix "zcache=" kernel parameter

2013-07-24 Thread Bartlomiej Zolnierkiewicz
Hi, On Wednesday, July 24, 2013 12:04:41 PM Michal Hocko wrote: > On Wed 24-07-13 12:02:35, Michal Hocko wrote: > > I have posted a similar fix quite some time ago and I guess Greg should > > already have it. > > For reference https://lkml.org/lkml/2013/6/26/410 There was a reply from Greg:

Re: [PATCH] zcache: fix "zcache=" kernel parameter

2013-07-24 Thread Michal Hocko
On Wed 24-07-13 12:02:35, Michal Hocko wrote: > I have posted a similar fix quite some time ago and I guess Greg should > already have it. For reference https://lkml.org/lkml/2013/6/26/410 > Greg? > > On Fri 19-07-13 16:46:41, Piotr Sarna wrote: > > Commit 835f2f5 ("staging: zcache: enable zcac

Re: [PATCH] zcache: fix "zcache=" kernel parameter

2013-07-24 Thread Michal Hocko
I have posted a similar fix quite some time ago and I guess Greg should already have it. Greg? On Fri 19-07-13 16:46:41, Piotr Sarna wrote: > Commit 835f2f5 ("staging: zcache: enable zcache to be built/loaded as > a module") introduced an incorrect handling of "zcache=" parameter. > > Inside zca