Re: [PATCH] staging:rtl8821ae: rewrite legacy wifi check in halbcoutsrc

2014-06-21 Thread Greg KH
On Sat, Jun 21, 2014 at 12:46:33PM -0400, Nick Krause wrote: > Hope you enjoyed your trips , Larry. > It would be great if you researched > this issue in order for me to send in > a correct patch to fix this bug. That is not how kernel development is done, you need to do the work, not ask others t

Re: [PATCH] staging:rtl8821ae: rewrite legacy wifi check in halbcoutsrc

2014-06-21 Thread Larry Finger
On 06/20/2014 09:52 PM, Nick Krause wrote: Is this patch being merged or is this not an issue. I am confused did I make a mistake in my patch or is there being a different patch being merged. Thank Nick On Fri, Jun 20, 2014 at 10:34 PM, Joe Perches wrote: On Fri, 2014-06-20 at 22:26 -0400, Nic

Re: [PATCH] staging:rtl8821ae: rewrite legacy wifi check in halbcoutsrc

2014-06-20 Thread Joe Perches
On Fri, 2014-06-20 at 22:26 -0400, Nick Krause wrote: > Thanks for the feedback I will resend the patch fixed. Please do not. > Otherwise please use Larry's idea. It's not Larry's idea. Larry is the primary contributor for Realtek drivers in staging. __

Re: [PATCH] staging:rtl8821ae: rewrite legacy wifi check in halbcoutsrc

2014-06-20 Thread Nick Krause
Is this patch being merged or is this not an issue. I am confused did I make a mistake in my patch or is there being a different patch being merged. Thank Nick On Fri, Jun 20, 2014 at 10:34 PM, Joe Perches wrote: > On Fri, 2014-06-20 at 22:26 -0400, Nick Krause wrote: >> Thanks for the feedback I

Re: [PATCH] staging:rtl8821ae: rewrite legacy wifi check in halbcoutsrc

2014-06-20 Thread Nick Krause
Thanks for the feedback I will resend the patch fixed. Otherwise please use Larry's idea. Cheers Nick On Fri, Jun 20, 2014 at 4:08 PM, Joe Perches wrote: > On Fri, 2014-06-20 at 22:59 +0300, Dan Carpenter wrote: >> On Fri, Jun 20, 2014 at 12:56:50PM -0400, Nicholas Krause wrote: >> > Rewrites the

Re: [PATCH] staging:rtl8821ae: rewrite legacy wifi check in halbcoutsrc

2014-06-20 Thread Joe Perches
On Fri, 2014-06-20 at 22:59 +0300, Dan Carpenter wrote: > On Fri, Jun 20, 2014 at 12:56:50PM -0400, Nicholas Krause wrote: > > Rewrites the wireless check for legacy checking in function > > halbtc_legacy to check for both Mode A and B. > > You're just guessing that A and B were intended but it co

Re: [PATCH] staging:rtl8821ae: rewrite legacy wifi check in halbcoutsrc

2014-06-20 Thread Dan Carpenter
On Fri, Jun 20, 2014 at 12:56:50PM -0400, Nicholas Krause wrote: > Rewrites the wireless check for legacy checking in function > halbtc_legacy to check for both Mode A and B. You're just guessing that A and B were intended but it could have been something B and G... Don't do this. Just leave the

[PATCH] staging:rtl8821ae: rewrite legacy wifi check in halbcoutsrc

2014-06-20 Thread Nicholas Krause
Rewrites the wireless check for legacy checking in function halbtc_legacy to check for both Mode A and B. Signed-off-by: Nicholas Krause --- drivers/staging/rtl8821ae/btcoexist/halbtcoutsrc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8821ae/btcoexist/