Re: [PATCH] staging: wimax/i2400m: fix coding style issues

2021-02-03 Thread Ayush
> Do you really not have a last name, like Cher? Exactly, my legal name only has first name. > > We generally want people to send these as separate patches. > > But in this case, we're just going to delete the driver. Don't bother > sending cleanups for this because it will be deleted soon. > >

Re: [PATCH] staging: wimax/i2400m: fix coding style issues

2021-02-03 Thread Ayush
> > - Your patch did many different things all at once, making it difficult > to review. All Linux kernel patches need to only do one thing at a > time. If you need to do multiple things (such as clean up all coding > style issues in a file/driver), do it in a sequence of patches, each > one doing

[PATCH] staging: wimax/i2400m: fix coding style issues

2021-02-03 Thread Ayush
- fix "multiple blank lines" issues. - fix a couple of parenthesis alignment issues. - fix no space before parenthesis issue. - fix no blank line after declaration. compile tested only (on next-20210202). Signed-off-by: Ayush --- drivers/staging/wimax/i2400m/debugfs.c | 20 +---

Re: [PATCH] staging: wimax/i2400m: fix coding style issues

2021-02-03 Thread Greg KH
On Wed, Feb 03, 2021 at 03:40:06PM +, Ayush wrote: > > > > - Your patch did many different things all at once, making it difficult > > to review. All Linux kernel patches need to only do one thing at a > > time. If you need to do multiple things (such as clean up all coding > > style issues in

Re: [PATCH] staging: wimax/i2400m: fix coding style issues

2021-02-03 Thread Dan Carpenter
Do you really not have a last name, like Cher? On Wed, Feb 03, 2021 at 05:17:20PM +0530, Ayush wrote: > - fix "multiple blank lines" issues. > - fix a couple of parenthesis alignment issues. > - fix no space before parenthesis issue. > - fix no blank line after declaration. > We generally want p

Re: [PATCH] staging: wimax/i2400m: fix coding style issues

2021-02-03 Thread Greg KH
On Wed, Feb 03, 2021 at 05:17:20PM +0530, Ayush wrote: > - fix "multiple blank lines" issues. > - fix a couple of parenthesis alignment issues. > - fix no space before parenthesis issue. > - fix no blank line after declaration. > > compile tested only (on next-20210202). > > Signed-off-by: Ayush