Re: [PATCH] staging: wilc100: Remove pointer and integer comparision

2015-08-11 Thread Chandra Gorentla
On Mon, Aug 10, 2015 at 09:38:56PM +0300, Dan Carpenter wrote: > Warnings are not a bad thing they are a valuable marker to let us know > which code is broken. If we just silence the warning in the laziest > possible way then we are throwing away valuable information. It's > better to leave the w

Re: [PATCH] staging: wilc100: Remove pointer and integer comparision

2015-08-10 Thread Dan Carpenter
Warnings are not a bad thing they are a valuable marker to let us know which code is broken. If we just silence the warning in the laziest possible way then we are throwing away valuable information. It's better to leave the warning there so that the next person can fix it properly. If you want

Re: [PATCH] staging: wilc100: Remove pointer and integer comparision

2015-08-10 Thread Chandra Gorentla
On Mon, Aug 10, 2015 at 07:27:13PM +0300, Dan Carpenter wrote: > On Mon, Aug 10, 2015 at 08:59:43PM +0530, Chandra Gorentla wrote: > > I agree with your suggestion > > that we need to take a broader look. Please help in understanding > > how does that broader look is suggesting that the patch is n

Re: [PATCH] staging: wilc100: Remove pointer and integer comparision

2015-08-10 Thread Dan Carpenter
On Mon, Aug 10, 2015 at 08:59:43PM +0530, Chandra Gorentla wrote: > I agree with your suggestion > that we need to take a broader look. Please help in understanding > how does that broader look is suggesting that the patch is not > addressing a right problem. The gcc version I am using is - 4.8.2

Re: [PATCH] staging: wilc100: Remove pointer and integer comparision

2015-08-10 Thread Chandra Gorentla
On Mon, Aug 10, 2015 at 12:39:43PM +0300, Dan Carpenter wrote: > On Sun, Aug 09, 2015 at 08:50:02PM +0530, Chandra S Gorentla wrote: > > Removed pointer check with integer; this fixes 'sparse' error - > > error: incompatible types for operation (>) > >left side has type unsigned char [usertype]

Re: [PATCH] staging: wilc100: Remove pointer and integer comparision

2015-08-10 Thread Dan Carpenter
On Sun, Aug 09, 2015 at 08:50:02PM +0530, Chandra S Gorentla wrote: > Removed pointer check with integer; this fixes 'sparse' error - > error: incompatible types for operation (>) >left side has type unsigned char [usertype] *[usertype] pu8Tail >right side has type int > > Signed-off-by: C

[PATCH] staging: wilc100: Remove pointer and integer comparision

2015-08-09 Thread Chandra S Gorentla
Removed pointer check with integer; this fixes 'sparse' error - error: incompatible types for operation (>) left side has type unsigned char [usertype] *[usertype] pu8Tail right side has type int Signed-off-by: Chandra S Gorentla --- drivers/staging/wilc1000/host_interface.c | 2 +- 1 file