Re: [PATCH] staging: vt6656: Use BIT() macro instead of hex value

2020-03-26 Thread Oscar Carter
On Mon, Mar 23, 2020 at 10:35:18AM +0300, Dan Carpenter wrote: > On Fri, Mar 20, 2020 at 06:10:56PM +0100, Oscar Carter wrote: > > -#define RSR_ADDRBROAD 0x80 > > -#define RSR_ADDRMULTI 0x40 > > +#define RSR_ADDRBROAD BIT(7) > > +#define RSR_ADDRMULTI BIT(6) > > #define RSR

Re: [PATCH] staging: vt6656: Use BIT() macro instead of hex value

2020-03-23 Thread Dan Carpenter
On Fri, Mar 20, 2020 at 06:10:56PM +0100, Oscar Carter wrote: > -#define RSR_ADDRBROAD 0x80 > -#define RSR_ADDRMULTI 0x40 > +#define RSR_ADDRBROAD BIT(7) > +#define RSR_ADDRMULTI BIT(6) > #define RSR_ADDRUNI 0x00 > -#define RSR_IVLDTYP 0x20/* invalid

[PATCH] staging: vt6656: Use BIT() macro instead of hex value

2020-03-20 Thread Oscar Carter
Use the BIT() macro instead of the hexadecimal value to define the different bits in registers. Signed-off-by: Oscar Carter --- drivers/staging/vt6656/desc.h | 35 ++--- drivers/staging/vt6656/device.h | 9 +- drivers/staging/vt6656/mac.h| 263 3 files c