Re: [PATCH] staging: vt6656: Fix dereference before NULL check

2014-04-25 Thread Tobias Klauser
On 2014-04-25 at 15:11:05 +0200, Dan Carpenter wrote: > On Fri, Apr 25, 2014 at 01:54:51PM +0200, Tobias Klauser wrote: > > pFifoHead is dereferenced before it is checked for NULL which implies it > > can potentially be NULL. Thus move the check before the dereference. > > > > Found by the coveri

Re: [PATCH] staging: vt6656: Fix dereference before NULL check

2014-04-25 Thread Dan Carpenter
On Fri, Apr 25, 2014 at 01:54:51PM +0200, Tobias Klauser wrote: > pFifoHead is dereferenced before it is checked for NULL which implies it > can potentially be NULL. Thus move the check before the dereference. > > Found by the coverity scanner, CID 1127221. > pFifoHead is this: struct vnt_tx_fi

[PATCH] staging: vt6656: Fix dereference before NULL check

2014-04-25 Thread Tobias Klauser
pFifoHead is dereferenced before it is checked for NULL which implies it can potentially be NULL. Thus move the check before the dereference. Found by the coverity scanner, CID 1127221. Reported-by: Signed-off-by: Tobias Klauser --- drivers/staging/vt6656/rxtx.c |6 +++--- 1 file changed,