Re: [PATCH] staging: vt6655: fix direct dereferencing of user pointer

2014-07-27 Thread Malcolm Priestley
On 27/07/14 19:21, Greg Kroah-Hartman wrote: On Sat, Jul 26, 2014 at 11:44:57AM +0100, Malcolm Priestley wrote: On 26/07/14 10:18, Guillaume CLÉMENT wrote: On Sat, Jul 26, 2014 at 10:24:30AM +0200, Guillaume CLÉMENT wrote: Hi Malcolm, On Sat, Jul 26, 2014 at 12:09:49AM +0100, Malcolm Priestle

Re: [PATCH] staging: vt6655: fix direct dereferencing of user pointer

2014-07-27 Thread Greg Kroah-Hartman
On Sat, Jul 26, 2014 at 11:44:57AM +0100, Malcolm Priestley wrote: > On 26/07/14 10:18, Guillaume CLÉMENT wrote: > >On Sat, Jul 26, 2014 at 10:24:30AM +0200, Guillaume CLÉMENT wrote: > >>Hi Malcolm, > >> > >>On Sat, Jul 26, 2014 at 12:09:49AM +0100, Malcolm Priestley wrote: > >>>Hi Guillaume > >>>

Re: [PATCH] staging: vt6655: fix direct dereferencing of user pointer

2014-07-26 Thread Malcolm Priestley
On 26/07/14 10:18, Guillaume CLÉMENT wrote: On Sat, Jul 26, 2014 at 10:24:30AM +0200, Guillaume CLÉMENT wrote: Hi Malcolm, On Sat, Jul 26, 2014 at 12:09:49AM +0100, Malcolm Priestley wrote: Hi Guillaume On 25/07/14 13:47, Guillaume Clement wrote: Sparse reported that the data from tagSCmdReq

Re: [PATCH] staging: vt6655: fix direct dereferencing of user pointer

2014-07-26 Thread Guillaume CLÉMENT
On Sat, Jul 26, 2014 at 10:24:30AM +0200, Guillaume CLÉMENT wrote: > Hi Malcolm, > > On Sat, Jul 26, 2014 at 12:09:49AM +0100, Malcolm Priestley wrote: > > Hi Guillaume > > > > On 25/07/14 13:47, Guillaume Clement wrote: > > > Sparse reported that the data from tagSCmdRequest is given by > > > user

Re: [PATCH] staging: vt6655: fix direct dereferencing of user pointer

2014-07-26 Thread Guillaume CLÉMENT
Hi Malcolm, On Sat, Jul 26, 2014 at 12:09:49AM +0100, Malcolm Priestley wrote: > Hi Guillaume > > On 25/07/14 13:47, Guillaume Clement wrote: > > Sparse reported that the data from tagSCmdRequest is given by > > userspace, so it should be tagged as such. > extra is not in user space > All right.

Re: [PATCH] staging: vt6655: fix direct dereferencing of user pointer

2014-07-25 Thread Malcolm Priestley
Hi Guillaume On 25/07/14 13:47, Guillaume Clement wrote: Sparse reported that the data from tagSCmdRequest is given by userspace, so it should be tagged as such. extra is not in user space All Wireless Extensions ioctl extra calls originate from ioctl_standard_iw_point in wext-core. Either

Re: [PATCH] staging: vt6655: fix direct dereferencing of user pointer

2014-07-25 Thread Malcolm Priestley
Hi Guillaume On 25/07/14 13:47, Guillaume Clement wrote: Sparse reported that the data from tagSCmdRequest is given by userspace, so it should be tagged as such. extra is not in user space All Wireless Extensions ioctl extra calls originate from ioctl_standard_iw_point in wext-core. Either

[PATCH] staging: vt6655: fix direct dereferencing of user pointer

2014-07-25 Thread Guillaume Clement
Sparse reported that the data from tagSCmdRequest is given by userspace, so it should be tagged as such. Later, we were memcomparing and dereferencing it without first copying it, fix that as well. Signed-off-by: Guillaume Clement --- drivers/staging/vt6655/iocmd.h | 2 +- drivers/staging/vt66