Re: [PATCH] staging: unisys: rework signal remove/insert to avoid sparse lock warnings

2015-01-17 Thread zach
On 17/01/15 20:37, Dan Carpenter wrote: > No one wants to follow a link to read the changelog. Just say explain > like "I made a new wrapper around the function that does the locking if > needed and removed the locking from inside the function." > > Otherwise the patch looks good. Could you re-w

Re: [PATCH] staging: unisys: rework signal remove/insert to avoid sparse lock warnings

2015-01-17 Thread Dan Carpenter
On Sat, Jan 17, 2015 at 08:00:09PM +1100, Zachary Warren wrote: > Avoids the following warnings from sparse: > visorchannel_funcs.c:457:9: warning: > context imbalance in 'visorchannel_signalremove' - different lock contexts > for basic block > visorchannel_funcs.c:512:9: warning: > context imba

[PATCH] staging: unisys: rework signal remove/insert to avoid sparse lock warnings

2015-01-17 Thread Zachary Warren
Avoids the following warnings from sparse: visorchannel_funcs.c:457:9: warning: context imbalance in 'visorchannel_signalremove' - different lock contexts for basic block visorchannel_funcs.c:512:9: warning: context imbalance in 'visorchannel_signalinsert' - different lock contexts for basic T