Re: [PATCH] staging: rts5208: fix always true condition

2014-02-15 Thread Dan Carpenter
On Sat, Feb 15, 2014 at 10:44:35AM +0100, Levente Kurusa wrote: > ANDing anything with 0x1E and expecting it to be not 0x03 will always > be true. AND instead with 0x03, so that we check the last two bits, > which should be what was intended there. > This one is less clear what the intent was. C

[PATCH] staging: rts5208: fix always true condition

2014-02-15 Thread Levente Kurusa
ANDing anything with 0x1E and expecting it to be not 0x03 will always be true. AND instead with 0x03, so that we check the last two bits, which should be what was intended there. Reported-by: David Binderman Signed-off-by: Levente Kurusa --- drivers/staging/rts5208/sd.c | 2 +- 1 file changed,