Re: [PATCH] staging: rtl8723au: Fix sparse warning: cast to restricted __le16

On 07/08/15 at 08:26am, Jes Sorensen wrote: > Johannes Postma writes: > > On 06/08/15 at 08:21am, Jes Sorensen wrote: > >> > >> Looks OK to me. Probably worth changing the *(usPtr + index) to be > >> usPtr[index] as well to make the code easier to read. > >> > >> Jes > >> > > > > Thank you for

Re: [PATCH] staging: rtl8723au: Fix sparse warning: cast to restricted __le16

Johannes Postma writes: > On 06/08/15 at 08:21am, Jes Sorensen wrote: >> >> Looks OK to me. Probably worth changing the *(usPtr + index) to be >> usPtr[index] as well to make the code easier to read. >> >> Jes >> > > Thank you for reviewing. I will make a seperate patch for that. I will > sen

Re: [PATCH] staging: rtl8723au: Fix sparse warning: cast to restricted __le16

On 06/08/15 at 08:21am, Jes Sorensen wrote: > > Looks OK to me. Probably worth changing the *(usPtr + index) to be > usPtr[index] as well to make the code easier to read. > > Jes > Thank you for reviewing. I will make a seperate patch for that. I will send it after this one is accepted. Or s

Re: [PATCH] staging: rtl8723au: Fix sparse warning: cast to restricted __le16

Johannes Postma writes: > usPtr is used as __le16 *, but was defined as u16 *. > This was reported by sparse as: > drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:1850:29: warning: cast to > restricted __le16 > > This patch fixes the type of usPtr. > > Signed-off-by: Johannes Postma > --- > dr

[PATCH] staging: rtl8723au: Fix sparse warning: cast to restricted __le16

usPtr is used as __le16 *, but was defined as u16 *. This was reported by sparse as: drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:1850:29: warning: cast to restricted __le16 This patch fixes the type of usPtr. Signed-off-by: Johannes Postma --- drivers/staging/rtl8723au/hal/rtl8723a_hal_in

Re: [PATCH] staging: rtl8723au: fix sparse warning

Juston Li writes: > change cast to __le16 to fix the following warning: > drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:1488:20: warning: cast to > restricted __le16 > > Signed-off-by: Juston Li > --- > drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 2 +- > 1 file changed, 1 insertion(

[PATCH] staging: rtl8723au: fix sparse warning

change cast to __le16 to fix the following warning: drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:1488:20: warning: cast to restricted __le16 Signed-off-by: Juston Li --- drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dr

Re: [PATCH] staging: rtl8723au: Fix sparse warning cast to restricted __le16

Marcus Folkesson writes: > This patch fixes the following sparse warnings: > > CHECK drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c > drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:265:37: warning: > cast to restricted __le16 > drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:267:

[PATCH] staging: rtl8723au: Fix sparse warning cast to restricted __le16

This patch fixes the following sparse warnings: CHECK drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:265:37: warning: cast to restricted __le16 drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:267:39: warning: cast to restricted __l

[PATCH] staging: rtl8723au: fix sparse warning

drivers/staging/rtl8723au/core/rtw_xmit.c:2375 warning: symbol 'rtl8723a_EfusePgPacketRead' was not declared. Should it be static? Function 'rtw_ack_tx_done23a' seems to be unused in current staging code. Signed-off-by: Alexey Tulia --- drivers/staging/rtl8723au/core/rtw_xmit.c | 9 - 1

Re: [PATCH] staging: rtl8723au: fix sparse warning

Aleh Suprunovich writes: > drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:747:1: warning: symbol > 'rtl8723a_EfusePgPacketRead' was not declared. Should it be static? > > Function 'rtl8723a_EfusePgPacketRead' seems to be unused in current > staging code. > > Before, it was available as 'static

[PATCH] staging: rtl8723au: fix sparse warning

drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:747:1: warning: symbol 'rtl8723a_EfusePgPacketRead' was not declared. Should it be static? Function 'rtl8723a_EfusePgPacketRead' seems to be unused in current staging code. Before, it was available as 'static s32 Hal_EfusePgPacketRead', but code t

Re: [PATCH] staging: rtl8723au: fix sparse warning

Clement Calmels writes: > From: Clément Calmels > > Found running sparse on the rtl8723au driver. > > CHECK drivers/staging/rtl8723au/core/rtw_cmd.c > drivers/staging/rtl8723au/core/rtw_cmd.c:1479:54: warning: incorrect type in > argument 2 (different base types) > drivers/staging/rtl8723au/

[PATCH] staging: rtl8723au: fix sparse warning

From: Clément Calmels Found running sparse on the rtl8723au driver. CHECK drivers/staging/rtl8723au/core/rtw_cmd.c drivers/staging/rtl8723au/core/rtw_cmd.c:1479:54: warning: incorrect type in argument 2 (different base types) drivers/staging/rtl8723au/core/rtw_cmd.c:1479:54:expected int

Re: [PATCH] staging/rtl8723au fix sparse warning in os_initfs.c

On Thu, May 15, 2014 at 10:43:34PM +0200, Konrad Zapalowicz wrote: > This commit fixes the following sparse warning: > > drivers/staging/rtl8723au/os_dep/os_intfs.c: > - 322:14: warning: restricted __be16 degrades to integer > > Signed-off-by: Konrad Zapalowicz > --- > drivers/staging/rtl87

[PATCH] staging/rtl8723au fix sparse warning in os_initfs.c

This commit fixes the following sparse warning: drivers/staging/rtl8723au/os_dep/os_intfs.c: - 322:14: warning: restricted __be16 degrades to integer Signed-off-by: Konrad Zapalowicz --- drivers/staging/rtl8723au/os_dep/os_intfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff