Re: [PATCH] staging: rtl8712: remove unused variables

2014-10-27 Thread Sudip Mukherjee
On Mon, Oct 27, 2014 at 03:12:57PM +0300, Dan Carpenter wrote: > On Mon, Oct 27, 2014 at 05:22:21PM +0530, Sudip Mukherjee wrote: > > On Mon, Oct 27, 2014 at 02:13:12PM +0300, Dan Carpenter wrote: > > > On Sun, Oct 26, 2014 at 06:03:33PM +0530, Sudip Mukherjee wrote: > > > > @@ -262,7 +257,7 @@ sta

Re: [PATCH] staging: rtl8712: remove unused variables

2014-10-27 Thread Dan Carpenter
On Mon, Oct 27, 2014 at 05:22:21PM +0530, Sudip Mukherjee wrote: > On Mon, Oct 27, 2014 at 02:13:12PM +0300, Dan Carpenter wrote: > > On Sun, Oct 26, 2014 at 06:03:33PM +0530, Sudip Mukherjee wrote: > > > @@ -262,7 +257,7 @@ static u8 rtl8712_dl_fw(struct _adapter *padapter) > > > if (tmp

Re: [PATCH] staging: rtl8712: remove unused variables

2014-10-27 Thread Sudip Mukherjee
On Mon, Oct 27, 2014 at 02:13:12PM +0300, Dan Carpenter wrote: > On Sun, Oct 26, 2014 at 06:03:33PM +0530, Sudip Mukherjee wrote: > > @@ -262,7 +257,7 @@ static u8 rtl8712_dl_fw(struct _adapter *padapter) > > if (tmp8_a != (tmp8|BIT(2))) > > goto exit_fail; > > > >

Re: [PATCH] staging: rtl8712: remove unused variables

2014-10-27 Thread Dan Carpenter
On Sun, Oct 26, 2014 at 06:03:33PM +0530, Sudip Mukherjee wrote: > @@ -262,7 +257,7 @@ static u8 rtl8712_dl_fw(struct _adapter *padapter) > if (tmp8_a != (tmp8|BIT(2))) > goto exit_fail; > > - tmp32 = r8712_read32(padapter, TCR); > + r87

[PATCH] staging: rtl8712: remove unused variables

2014-10-26 Thread Sudip Mukherjee
unused variables are removed. These variables were only assigned some values and after that they were never being used. So they are safe to be removed , and it has been build tested. Signed-off-by: Sudip Mukherjee --- drivers/staging/rtl8712/hal_init.c| 9 ++--- drivers/staging/