[PATCH] staging: rtl8712: Remove unnecessary ret variable

2016-02-14 Thread Joseph Bisch
Since the variable ret is set at the beginning of the function and never changes its value, we can just return the value it was set to. Found using coccinelle with misc/returnvar.cocci. Signed-off-by: Joseph Bisch --- drivers/staging/rtl8712/os_intfs.c | 3 +-- 1 file changed, 1 insertion(+), 2

Re: [PATCH] staging: rtl8712: Remove unnecessary ret variable

2016-02-14 Thread Greg KH
On Sun, Feb 14, 2016 at 04:34:17PM -0500, Joseph Bisch wrote: > I am forwarding this patch that I previously sent to the three people > listed in drivers/staging/rtl8712/TODO. > -- Why is the above here in the body of the patch? Please remove it, I don't want to have to hand-edit the patch in ord

[PATCH] staging: rtl8712: Remove unnecessary ret variable

2016-02-14 Thread Joseph Bisch
I am forwarding this patch that I previously sent to the three people listed in drivers/staging/rtl8712/TODO. -- Since the variable ret is set at the beginning of the function and never changes its value, we can just return the value it was set to. Found using coccinelle with misc/returnvar.cocci.