Re: [Outreachy kernel] [PATCH] staging: rtl8712: Add comment to lock declaration

2019-10-09 Thread Jules Irenge
On Mon, 7 Oct 2019, Julia Lawall wrote: On Mon, 7 Oct 2019, Jules Irenge wrote: Add comment to spinlock declaration to fix warning issued by checkpatch.pl "CHECK: spinlock_t definition without comment". Since it is not apparent from the shown code, it would be helpful to describe what e

Re: [PATCH] staging: rtl8712: Add comment to lock declaration

2019-10-07 Thread Dan Carpenter
On Mon, Oct 07, 2019 at 09:52:48PM +0100, Jules Irenge wrote: > Add comment to spinlock declaration to fix warning issued by checkpatch.pl > "CHECK: spinlock_t definition without comment". > > Signed-off-by: Jules Irenge > --- > drivers/staging/rtl8712/drv_types.h | 2 +- > 1 file changed, 1 ins

Re: [Outreachy kernel] [PATCH] staging: rtl8712: Add comment to lock declaration

2019-10-07 Thread Julia Lawall
On Mon, 7 Oct 2019, Jules Irenge wrote: > Add comment to spinlock declaration to fix warning issued by checkpatch.pl > "CHECK: spinlock_t definition without comment". Since it is not apparent from the shown code, it would be helpful to describe what evidence you used to choose this comment. t

[PATCH] staging: rtl8712: Add comment to lock declaration

2019-10-07 Thread Jules Irenge
Add comment to spinlock declaration to fix warning issued by checkpatch.pl "CHECK: spinlock_t definition without comment". Signed-off-by: Jules Irenge --- drivers/staging/rtl8712/drv_types.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8712/drv_types.h