Re: [PATCH] staging: rtl8192u: simplify conditional statement

2015-10-15 Thread kbuild test robot
Hi Luis, [auto build test WARNING on staging/staging-next -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url: https://github.com/0day-ci/linux/commits/Luis-de-Bethencourt/staging-rtl8192u-simplify-conditional-statement/20151015-203425 config: i386-a

Re: [PATCH] staging: rtl8192u: simplify conditional statement

2015-10-15 Thread Dan Carpenter
On Thu, Oct 15, 2015 at 01:33:14PM +0100, Luis de Bethencourt wrote: > diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c > b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c > index c443e2e..1c2d1a4 100644 > --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c > +++

[PATCH] staging: rtl8192u: simplify conditional statement

2015-10-15 Thread Luis de Bethencourt
The code can be much cleaner and readable by simplifying the conditional statement. Only need to check if (ieee->state > IEEE80211_LINKED) and not >= because (ieee->state == IEEE80211_LINKED) is already checked a few lines above. Signed-off-by: Luis de Bethencourt --- drivers/staging/rtl8192u/i