Re: [PATCH] staging: rtl8192u: remove redundant null check on array 'data'

2019-04-04 Thread Mukesh Ojha
On 4/4/2019 3:02 PM, Colin King wrote: From: Colin Ian King The NULL check on ram->u.wpa_ie.data is redudant as data is s/redudant/redundant zero-length array and is not a pointer, so it can't be null. Remove the check. Addresses-Coverity: ("Array compared against 0") Signed-off-by: Colin

Re: [PATCH] staging: rtl8192u: remove redundant null check on array 'data'

2019-04-04 Thread Dan Carpenter
On Thu, Apr 04, 2019 at 10:32:57AM +0100, Colin King wrote: > diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c > b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c > index 944c8894f9ff..c4a4f118f547 100644 > --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c > ++

[PATCH] staging: rtl8192u: remove redundant null check on array 'data'

2019-04-04 Thread Colin King
From: Colin Ian King The NULL check on ram->u.wpa_ie.data is redudant as data is zero-length array and is not a pointer, so it can't be null. Remove the check. Addresses-Coverity: ("Array compared against 0") Signed-off-by: Colin Ian King --- drivers/staging/rtl8192u/ieee80211/ieee80211_softma