Re: [PATCH] staging: pi433: remove unnecessary parentheses

2018-01-10 Thread marcus . wolf
Joe Perches schrieb am 10.01.2018 10:05: > On Wed, 2018-01-10 at 09:44 +0100, Greg Kroah-Hartman wrote: > > On Tue, Jan 09, 2018 at 11:42:16AM -0800, Joe Perches wrote: > > > if (a == b && c == d) > > > is pretty trivial. > > > > But again, don't do that. > > We disagree. Life goes on. > > cheer

Re: [PATCH] staging: pi433: remove unnecessary parentheses

2018-01-10 Thread Joe Perches
On Wed, 2018-01-10 at 09:44 +0100, Greg Kroah-Hartman wrote: > On Tue, Jan 09, 2018 at 11:42:16AM -0800, Joe Perches wrote: > > if (a == b && c == d) > > is pretty trivial. > > But again, don't do that. We disagree. Life goes on. cheers, Joe __

Re: [PATCH] staging: pi433: remove unnecessary parentheses

2018-01-10 Thread Greg Kroah-Hartman
On Tue, Jan 09, 2018 at 11:42:16AM -0800, Joe Perches wrote: > On Tue, 2018-01-09 at 20:28 +0100, Greg Kroah-Hartman wrote: > > On Tue, Jan 09, 2018 at 11:21:37AM -0800, Joe Perches wrote: > > > On Tue, 2018-01-09 at 15:31 +0100, Greg Kroah-Hartman wrote: > > > > On Mon, Jan 08, 2018 at 06:38:55PM

Re: [PATCH] staging: pi433: remove unnecessary parentheses

2018-01-09 Thread Joe Perches
On Tue, 2018-01-09 at 20:28 +0100, Greg Kroah-Hartman wrote: > On Tue, Jan 09, 2018 at 11:21:37AM -0800, Joe Perches wrote: > > On Tue, 2018-01-09 at 15:31 +0100, Greg Kroah-Hartman wrote: > > > On Mon, Jan 08, 2018 at 06:38:55PM +0100, Valentin Vidic wrote: > > > > Fixes checkpatch warnings: > > >

Re: [PATCH] staging: pi433: remove unnecessary parentheses

2018-01-09 Thread Joe Perches
On Tue, 2018-01-09 at 15:31 +0100, Greg Kroah-Hartman wrote: > On Mon, Jan 08, 2018 at 06:38:55PM +0100, Valentin Vidic wrote: > > Fixes checkpatch warnings: > > CHECK: Unnecessary parentheses around 'mantisse != mantisse16' > > CHECK: Unnecessary parentheses around 'mantisse != mantisse20' > >

Re: [PATCH] staging: pi433: remove unnecessary parentheses

2018-01-09 Thread Greg Kroah-Hartman
On Tue, Jan 09, 2018 at 11:21:37AM -0800, Joe Perches wrote: > On Tue, 2018-01-09 at 15:31 +0100, Greg Kroah-Hartman wrote: > > On Mon, Jan 08, 2018 at 06:38:55PM +0100, Valentin Vidic wrote: > > > Fixes checkpatch warnings: > > > CHECK: Unnecessary parentheses around 'mantisse != mantisse16' > >

Re: [PATCH] staging: pi433: remove unnecessary parentheses

2018-01-09 Thread Greg Kroah-Hartman
On Mon, Jan 08, 2018 at 06:38:55PM +0100, Valentin Vidic wrote: > Fixes checkpatch warnings: > > CHECK: Unnecessary parentheses around 'mantisse != mantisse16' > CHECK: Unnecessary parentheses around 'mantisse != mantisse20' > CHECK: Unnecessary parentheses around 'mantisse != mantisse24' >

[PATCH] staging: pi433: remove unnecessary parentheses

2018-01-08 Thread Valentin Vidic
Fixes checkpatch warnings: CHECK: Unnecessary parentheses around 'mantisse != mantisse16' CHECK: Unnecessary parentheses around 'mantisse != mantisse20' CHECK: Unnecessary parentheses around 'mantisse != mantisse24' Signed-off-by: Valentin Vidic --- drivers/staging/pi433/rf69.c | 6 +++---