Hi Dan,
the "big" patch, I was telling about yesterday will touch exactly that file.
So if you are planning deep changes, we will most probably run into conflicts.
If I'll find some time (maybe tomorrow), I'll try to send that long patch, so
you can see.
Already nervous about next failing patch
On Sat, Jul 29, 2017 at 11:16:11AM +0200, Marcus Wolf wrote:
> Hi Greg,
>
> there is another patch from me (see subject). I sent it 19/07/2017.
>
> Most probably, there is also something wrong with the patch, but maybe you can
> get it to work.
>
> The patch would be important. It doesn't fix a
Hi Greg,
there is another patch from me (see subject). I sent it 19/07/2017.
Most probably, there is also something wrong with the patch, but maybe you can
get it to work.
The patch would be important. It doesn't fix any warnings or errors of static
code analysis, but it fixes true implementati
Am 20.07.2017 18:08, schrieb Marcus Wolf:
> Hi Walter,
>
> since the construction
>
> WRITE_REG(REG_LNA, ( (READ_REG(REG_LNA) & ~MASK_LNA_GAIN) |
> LNA_GAIN_MAX_MINUS_6) )
> aka
> WRITE_REG(regname, ( (READ_REG(regname) & ~regmask ) | vale
>) )
>
> is used nearly everywhe
Hi Walter,
since the construction
WRITE_REG(REG_LNA, ( (READ_REG(REG_LNA) & ~MASK_LNA_GAIN) |
LNA_GAIN_MAX_MINUS_6) )
aka
WRITE_REG(regname, ( (READ_REG(regname) & ~regmask ) | vale
) )
is used nearly everywhere, I think, about using a more gneric macro like
#define READ_MO
Am 19.07.2017 20:18, schrieb Wolf Entwicklungen:
> Bugfixes for rf69_set_modulation, rf69_set_deviation, rf69_set_lna_gain and
> rf69_get_lna_gain
> The fixes are cross-checked with the datasheet of the rfm69cw
>
> Fixes: 874bcba65f9a ("staging: pi433: New driver")
> Signed-off-by: Marcus Wolf
Bugfixes for rf69_set_modulation, rf69_set_deviation, rf69_set_lna_gain and
rf69_get_lna_gain
The fixes are cross-checked with the datasheet of the rfm69cw
Fixes: 874bcba65f9a ("staging: pi433: New driver")
Signed-off-by: Marcus Wolf
diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/p