Re: [PATCH] staging: pi433: #define shift constants in rf69.c

2017-11-08 Thread Josh Abraham
On Wed, Nov 08, 2017 at 02:52:30PM +0300, Dan Carpenter wrote: > On Wed, Nov 08, 2017 at 06:25:06AM -0500, Joshua Abraham wrote: > > This patch completes TODO improvements in rf69.c to change shift > > constants to a define. > > > > Signed-off-by: Joshua Abraham > > --- > > drivers/staging/pi433

Re: [PATCH] staging: pi433: #define shift constants in rf69.c

2017-11-08 Thread Marcus Wolf
Hello everybody! Concerning the naming: == When writing the rf69.c it wasn't intended to write a driver for Linux. This file was written at a time, where the complete controlling of Pi433 was implemented in the application. Therefore it is written in a completely different

Re: [PATCH] staging: pi433: #define shift constants in rf69.c

2017-11-08 Thread Dan Carpenter
On Wed, Nov 08, 2017 at 06:25:06AM -0500, Joshua Abraham wrote: > This patch completes TODO improvements in rf69.c to change shift > constants to a define. > > Signed-off-by: Joshua Abraham > --- > drivers/staging/pi433/rf69.c | 4 ++-- > drivers/staging/pi433/rf69_registers.h | 4

[PATCH] staging: pi433: #define shift constants in rf69.c

2017-11-08 Thread Joshua Abraham
This patch completes TODO improvements in rf69.c to change shift constants to a define. Signed-off-by: Joshua Abraham --- drivers/staging/pi433/rf69.c | 4 ++-- drivers/staging/pi433/rf69_registers.h | 4 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/stagi