Re: [PATCH] staging: panel: remove duplicate code

2015-04-07 Thread Sudip Mukherjee
On Tue, Apr 07, 2015 at 12:12:06PM +0200, Greg Kroah-Hartman wrote: > On Tue, Apr 07, 2015 at 03:26:58PM +0530, Sudip Mukherjee wrote: > > On Tue, Apr 07, 2015 at 11:44:29AM +0200, Greg Kroah-Hartman wrote: > > > On Tue, Apr 07, 2015 at 02:55:02PM +0530, Sudip Mukherjee wrote: > > > > On Tue, Apr 0

Re: [PATCH] staging: panel: remove duplicate code

2015-04-07 Thread Willy Tarreau
On Tue, Apr 07, 2015 at 07:51:17PM +0530, Sudip Mukherjee wrote: > On Tue, Apr 07, 2015 at 04:14:59PM +0200, Willy Tarreau wrote: > > Not-so-old laptops used to have parport connectors for a while, and can be > > found at a very cheap price or even for free by now with dead batteries. > free laptop

Re: [PATCH] staging: panel: remove duplicate code

2015-04-07 Thread Sudip Mukherjee
On Tue, Apr 07, 2015 at 04:14:59PM +0200, Willy Tarreau wrote: > > > > > now. do you think it is worth that i pick up the code and modify > > > > > it for our latest kernel and submit to Greg ? > > > > > > > > If you have some parport hardware, and want to take it on, that would be > > > > great.

Re: [PATCH] staging: panel: remove duplicate code

2015-04-07 Thread Willy Tarreau
On Tue, Apr 07, 2015 at 12:12:06PM +0200, Greg Kroah-Hartman wrote: > On Tue, Apr 07, 2015 at 03:26:58PM +0530, Sudip Mukherjee wrote: > > On Tue, Apr 07, 2015 at 11:44:29AM +0200, Greg Kroah-Hartman wrote: > > > On Tue, Apr 07, 2015 at 02:55:02PM +0530, Sudip Mukherjee wrote: > > > > On Tue, Apr 0

Re: [PATCH] staging: panel: remove duplicate code

2015-04-07 Thread Sudip Mukherjee
On Tue, Apr 07, 2015 at 12:45:23PM +0300, Dan Carpenter wrote: > On Tue, Apr 07, 2015 at 02:55:02PM +0530, Sudip Mukherjee wrote: > > If you write the patch then I will review it. :) sure, I am on it. > > > lack of ppscsi.I mailed Tim Waugh, but he is not interested to work > > with ppscsi any

Re: [PATCH] staging: panel: remove duplicate code

2015-04-07 Thread Greg Kroah-Hartman
On Tue, Apr 07, 2015 at 03:26:58PM +0530, Sudip Mukherjee wrote: > On Tue, Apr 07, 2015 at 11:44:29AM +0200, Greg Kroah-Hartman wrote: > > On Tue, Apr 07, 2015 at 02:55:02PM +0530, Sudip Mukherjee wrote: > > > On Tue, Apr 07, 2015 at 11:49:30AM +0300, Dan Carpenter wrote: > > > > On Tue, Apr 07, 20

Re: [PATCH] staging: panel: remove duplicate code

2015-04-07 Thread Sudip Mukherjee
On Tue, Apr 07, 2015 at 11:44:29AM +0200, Greg Kroah-Hartman wrote: > On Tue, Apr 07, 2015 at 02:55:02PM +0530, Sudip Mukherjee wrote: > > On Tue, Apr 07, 2015 at 11:49:30AM +0300, Dan Carpenter wrote: > > > On Tue, Apr 07, 2015 at 01:55:01PM +0530, Sudip Mukherjee wrote: > > > > > > I hadn't look

Re: [PATCH] staging: panel: remove duplicate code

2015-04-07 Thread Dan Carpenter
On Tue, Apr 07, 2015 at 02:55:02PM +0530, Sudip Mukherjee wrote: > On Tue, Apr 07, 2015 at 11:49:30AM +0300, Dan Carpenter wrote: > > On Tue, Apr 07, 2015 at 01:55:01PM +0530, Sudip Mukherjee wrote: > > > > I hadn't looked at this driver much before. It sucks that > > parport_driver ->attach() fu

Re: [PATCH] staging: panel: remove duplicate code

2015-04-07 Thread Greg Kroah-Hartman
On Tue, Apr 07, 2015 at 02:55:02PM +0530, Sudip Mukherjee wrote: > On Tue, Apr 07, 2015 at 11:49:30AM +0300, Dan Carpenter wrote: > > On Tue, Apr 07, 2015 at 01:55:01PM +0530, Sudip Mukherjee wrote: > > > > I hadn't looked at this driver much before. It sucks that > > parport_driver ->attach() fu

Re: [PATCH] staging: panel: remove duplicate code

2015-04-07 Thread Sudip Mukherjee
On Tue, Apr 07, 2015 at 11:49:30AM +0300, Dan Carpenter wrote: > On Tue, Apr 07, 2015 at 01:55:01PM +0530, Sudip Mukherjee wrote: > > I hadn't looked at this driver much before. It sucks that > parport_driver ->attach() functions can't fail... then maybe, we can change the code of parport. curr

Re: [PATCH] staging: panel: remove duplicate code

2015-04-07 Thread Dan Carpenter
On Tue, Apr 07, 2015 at 01:55:01PM +0530, Sudip Mukherjee wrote: > both the misc_deregister(), parport_release() and > parport_unregister_device() is there in the module_exit function also. > detach is called from parport_unregister_driver() and by the time > detach executes misc_deregister(), parp

[PATCH] staging: panel: remove duplicate code

2015-04-07 Thread Sudip Mukherjee
both the misc_deregister(), parport_release() and parport_unregister_device() is there in the module_exit function also. detach is called from parport_unregister_driver() and by the time detach executes misc_deregister(), parport_release() and parport_unregister_device() has already executed markin