Re: [PATCH] staging: media: Replace a bit shift by a use of BIT.

2017-03-22 Thread Dilger, Andreas
On Mar 22, 2017, at 00:20, Arushi Singhal wrote: > > This patch replaces bit shifting on 1 with the BIT(x) macro. > This was done with coccinelle: > @@ > constant c; > @@ > > -1 << c > +BIT(c) Hi Arushi, thanks for taking time to contribute to the kernel. There are a few problems with this p

Re: [Outreachy kernel] [PATCH] staging: media: Replace a bit shift by a use of BIT.

2017-03-22 Thread Julia Lawall
On Wed, 22 Mar 2017, Arushi Singhal wrote: > This patch replaces bit shifting on 1 with the BIT(x) macro. > This was done with coccinelle: > @@ > constant c; > @@ > > -1 << c > +BIT(c) > > Signed-off-by: Arushi Singhal > --- > drivers/staging/octeon/ethernet-tx.c | 4 ++-- What is the connecti

[PATCH] staging: media: Replace a bit shift by a use of BIT.

2017-03-21 Thread Arushi Singhal
This patch replaces bit shifting on 1 with the BIT(x) macro. This was done with coccinelle: @@ constant c; @@ -1 << c +BIT(c) Signed-off-by: Arushi Singhal --- drivers/staging/octeon/ethernet-tx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/octeon/eth