Re: [PATCH] staging: lustre: ptlrpc: add missing include directive

2015-08-15 Thread Greg KH
On Sat, Aug 15, 2015 at 11:13:39AM +0300, Ioan-Adrian Ratiu wrote: > On Fri, 14 Aug 2015 18:50:24 -0700 > Greg KH wrote: > > > On Fri, Aug 14, 2015 at 12:57:06PM +0300, Ioan-Adrian Ratiu wrote: > > > Without including ptlrpc_internal.h, GCC gives prototype warnings > > > "pack_generic.c:642:5: wa

Re: [HPDD-discuss] [PATCH] staging: lustre: ptlrpc: add missing include directive

2015-08-15 Thread Drokin, Oleg
Hello! On Aug 15, 2015, at 4:13 AM, Ioan-Adrian Ratiu wrote: >>> Without including ptlrpc_internal.h, GCC gives prototype warnings >>> "pack_generic.c:642:5: warning: no previous prototype for ..." >> It does? What version of gcc give you that, I don't see that here. > Yes, but it's a non-defaul

Re: [PATCH] staging: lustre: ptlrpc: add missing include directive

2015-08-15 Thread Ioan-Adrian Ratiu
On Fri, 14 Aug 2015 18:50:24 -0700 Greg KH wrote: > On Fri, Aug 14, 2015 at 12:57:06PM +0300, Ioan-Adrian Ratiu wrote: > > Without including ptlrpc_internal.h, GCC gives prototype warnings > > "pack_generic.c:642:5: warning: no previous prototype for ..." > > It does? What version of gcc give y

Re: [PATCH] staging: lustre: ptlrpc: add missing include directive

2015-08-14 Thread Greg KH
On Fri, Aug 14, 2015 at 12:57:06PM +0300, Ioan-Adrian Ratiu wrote: > Without including ptlrpc_internal.h, GCC gives prototype warnings > "pack_generic.c:642:5: warning: no previous prototype for ..." It does? What version of gcc give you that, I don't see that here. _

[PATCH] staging: lustre: ptlrpc: add missing include directive

2015-08-14 Thread Ioan-Adrian Ratiu
Without including ptlrpc_internal.h, GCC gives prototype warnings "pack_generic.c:642:5: warning: no previous prototype for ..." and sparse also complains "pack_generic.c:642:5: warning: symbol 'lustre_unpack_req_ptlrpc_body' was not declared. ..." Signed-off-by: Ioan-Adrian Ratiu --- drivers/st