Re: [PATCH] staging: lustre: make functions as static

2014-02-26 Thread DaeSeok Youn
Oh.. sorry. Ok, I will seperate this patch as you said. Thanks. Daeseok Youn. 2014-02-26 20:31 GMT+09:00, Dan Carpenter : > On Wed, Feb 26, 2014 at 08:11:40PM +0900, DaeSeok Youn wrote: >> Actually , I saw some code like this file which is seperate line >> between return value and function name.

Re: [PATCH] staging: lustre: make functions as static

2014-02-26 Thread Dan Carpenter
On Wed, Feb 26, 2014 at 08:11:40PM +0900, DaeSeok Youn wrote: > Actually , I saw some code like this file which is seperate line > between return value and function name. > So I didn't make one line of them. > > Ok, I will make another patch after merge this one. No, you are misunderstanding what

Re: [PATCH] staging: lustre: make functions as static

2014-02-26 Thread DaeSeok Youn
Actually , I saw some code like this file which is seperate line between return value and function name. So I didn't make one line of them. Ok, I will make another patch after merge this one. Thanks. Daeseok Youn. 2014-02-26 18:20 GMT+09:00, Dan Carpenter : > On Wed, Feb 26, 2014 at 06:17:59PM +0

Re: [PATCH] staging: lustre: make functions as static

2014-02-26 Thread Dan Carpenter
On Wed, Feb 26, 2014 at 06:17:59PM +0900, Daeseok Youn wrote: > > These functions are only referenced in this file scope > so it can be marked static. > And remove space between function name and open parenthesis. If it's on the same line as a "static" change then it's fine, otherwise it should g

[PATCH] staging: lustre: make functions as static

2014-02-26 Thread Daeseok Youn
These functions are only referenced in this file scope so it can be marked static. And remove space between function name and open parenthesis. Signed-off-by: Daeseok Youn --- .../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c| 94 ++-- 1 file changed, 47 insertions(+), 47 de