Re: [PATCH] staging: lustre: libcfs: add parens around macros args

2018-05-30 Thread Dan Carpenter
On Tue, May 22, 2018 at 04:34:39PM +0300, Ivan Bornyakov wrote: > One may call 'CFS_FAIL_TIMEOUT(id, secs + 5);' and get unexpected result > after macro substitution, viz., 'secs + 5' will turn into > 'secs + 5 * 1000' > We actually do that in ptl_send_rpc() as well so this is a real bug. It's s

[PATCH] staging: lustre: libcfs: add parens around macros args

2018-05-22 Thread Ivan Bornyakov
One may call 'CFS_FAIL_TIMEOUT(id, secs + 5);' and get unexpected result after macro substitution, viz., 'secs + 5' will turn into 'secs + 5 * 1000' Signed-off-by: Ivan Bornyakov --- drivers/staging/lustre/include/linux/libcfs/libcfs_fail.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletion