Re: [lustre-devel] [PATCH] staging: lustre: fix sparse warning about different address spaces

2017-03-06 Thread Oleg Drokin
On Mar 1, 2017, at 6:57 PM, Mario Bambagini wrote: > fixed the following sparse warning by adding proper cast: > drivers/staging//lustre/lustre/obdclass/obd_config.c:1055:74: warning: > incorrect type in argument 2 (different address spaces) > drivers/staging//lustre/lustre/obdclass/obd_config.c

[PATCH] staging: lustre: fix sparse warning about different address spaces

2017-03-01 Thread Mario Bambagini
fixed the following sparse warning by adding proper cast: drivers/staging//lustre/lustre/obdclass/obd_config.c:1055:74: warning: incorrect type in argument 2 (different address spaces) drivers/staging//lustre/lustre/obdclass/obd_config.c:1055:74:expected char const [noderef] * drivers/staging

[PATCH] staging: lustre: fix sparse warning

2015-04-05 Thread Tal Shorer
Sparse reports: drivers/staging/lustre/lustre/obdclass/obd_mount.c:1284:6: warning: symbol 'lustre_kill_super' was not declared. Should it be static? Fix this warning by making lustre_kill_super static. It is not used outside this file. Signed-off-by: Tal Shorer --- drivers/staging/lustre/lus

Re: [PATCH] staging: lustre: fix sparse warning on LPROC_SEQ_FOPS macros

2014-12-06 Thread Tristan Lelong
Andreas, On Sat, Dec 06, 2014 at 05:05:14PM +, Dilger, Andreas wrote: > On 2014/12/05, 3:41 PM, "Tristan Lelong" wrote: > > > Sorry, but I don't see where you get 80 from? fh_name is declared as a > "const char *", and initialized in the declaration of fld_hash[]. I'd > thought to reply t

Re: [PATCH] staging: lustre: fix sparse warning on LPROC_SEQ_FOPS macros

2014-12-06 Thread Dilger, Andreas
On 2014/12/05, 3:41 PM, "Tristan Lelong" wrote: >On Fri, Dec 05, 2014 at 01:27:23PM -0800, Greg KH wrote: >> On Fri, Dec 05, 2014 at 12:03:47AM -0800, Tristan Lelong wrote: >> > static ssize_t >> > -fld_proc_hash_seq_write(struct file *file, const char *buffer, >> > - size_t cou

Re: [PATCH] staging: lustre: fix sparse warning on LPROC_SEQ_FOPS macros

2014-12-05 Thread Tristan Lelong
On Fri, Dec 05, 2014 at 01:27:23PM -0800, Greg KH wrote: > On Fri, Dec 05, 2014 at 12:03:47AM -0800, Tristan Lelong wrote: > > static ssize_t > > -fld_proc_hash_seq_write(struct file *file, const char *buffer, > > - size_t count, loff_t *off) > > +fld_proc_hash_seq_write(struct f

Re: [PATCH] staging: lustre: fix sparse warning on LPROC_SEQ_FOPS macros

2014-12-05 Thread Tristan Lelong
On Fri, Dec 05, 2014 at 12:44:07AM -0800, Joe Perches wrote: > On Fri, 2014-12-05 at 00:37 -0800, Tristan Lelong wrote: > > On Fri, Dec 05, 2014 at 12:28:11AM -0800, Joe Perches wrote: > > > On Fri, 2014-12-05 at 00:03 -0800, Tristan Lelong wrote: > [] > > > > diff --git a/drivers/staging/lustre/lu

Re: [PATCH] staging: lustre: fix sparse warning on LPROC_SEQ_FOPS macros

2014-12-05 Thread Greg KH
On Fri, Dec 05, 2014 at 12:03:47AM -0800, Tristan Lelong wrote: > This patch fix a sparse warning in lustre sources > > warning: incorrect type in argument 1 (different address spaces) > expected void [noderef] *to > got char * > > This is done by adding the missing __user attribute on us

Re: [PATCH] staging: lustre: fix sparse warning on LPROC_SEQ_FOPS macros

2014-12-05 Thread Joe Perches
On Fri, 2014-12-05 at 00:03 -0800, Tristan Lelong wrote: > This patch fix a sparse warning in lustre sources > > warning: incorrect type in argument 1 (different address spaces) > expected void [noderef] *to > got char * [] > diff --git a/drivers/staging/lustre/lustre/fld/lproc_fld.c > b/

Re: [PATCH] staging: lustre: fix sparse warning on LPROC_SEQ_FOPS macros

2014-12-05 Thread Joe Perches
On Fri, 2014-12-05 at 00:37 -0800, Tristan Lelong wrote: > On Fri, Dec 05, 2014 at 12:28:11AM -0800, Joe Perches wrote: > > On Fri, 2014-12-05 at 00:03 -0800, Tristan Lelong wrote: [] > > > diff --git a/drivers/staging/lustre/lustre/fld/lproc_fld.c > > > b/drivers/staging/lustre/lustre/fld/lproc_f

Re: [PATCH] staging: lustre: fix sparse warning on LPROC_SEQ_FOPS macros

2014-12-05 Thread Tristan Lelong
On Fri, Dec 05, 2014 at 12:28:11AM -0800, Joe Perches wrote: > On Fri, 2014-12-05 at 00:03 -0800, Tristan Lelong wrote: > > This patch fix a sparse warning in lustre sources > > > > warning: incorrect type in argument 1 (different address spaces) > > expected void [noderef] *to > > got cha

[PATCH] staging: lustre: fix sparse warning on LPROC_SEQ_FOPS macros

2014-12-05 Thread Tristan Lelong
This patch fix a sparse warning in lustre sources warning: incorrect type in argument 1 (different address spaces) expected void [noderef] *to got char * This is done by adding the missing __user attribute on userland pointers inside the LPROC_SEQ_FOPS-like macros: - LPROC_SEQ_FOPS - LPRO

Re: [PATCH] staging: lustre: fix sparse warning for static declarations

2014-10-29 Thread Greg Kroah-Hartman
On Sat, Oct 25, 2014 at 07:09:34PM +, Junien Fridrick wrote: > This patch fixes the following sparse warnings : > > drivers/staging/lustre/lnet/lnet/router_proc.c:167:5: warning: symbol > 'proc_lnet_routes' was not declared. Should it be static? > drivers/staging/lustre/lnet/lnet/router_proc.

[PATCH] staging: lustre: fix sparse warning for static declarations

2014-10-25 Thread Junien Fridrick
This patch fixes the following sparse warnings : drivers/staging/lustre/lnet/lnet/router_proc.c:167:5: warning: symbol 'proc_lnet_routes' was not declared. Should it be static? drivers/staging/lustre/lnet/lnet/router_proc.c:293:5: warning: symbol 'proc_lnet_routers' was not declared. Should it b

[PATCH] staging/lustre: fix sparse warning

2014-04-14 Thread Denis Pithon
Fix sparse complaint: "Using plain integer as NULL pointer" Signed-off-by: Denis Pithon --- drivers/staging/lustre/lustre/ptlrpc/sec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/ptlrpc/sec.c b/drivers/staging/lustre/lustre/ptlrpc/sec.c inde