Re: [PATCH] staging: lustre: Replace a bit shift by a use of BIT.

2017-03-23 Thread Dilger, Andreas
On Mar 22, 2017, at 06:12, Dilger, Andreas wrote: > > On Mar 21, 2017, at 22:39, Arushi Singhal > wrote: >> >> This patch replaces bit shifting on 1 with the BIT(x) macro. >> This was done with coccinelle: [snip] >> diff --git a/drivers/staging/lustre/lnet/lnet/net_fault.c >> b/drivers/stagin

Re: [PATCH] staging: lustre: Replace a bit shift by a use of BIT.

2017-03-22 Thread Dilger, Andreas
On Mar 21, 2017, at 22:39, Arushi Singhal wrote: > > This patch replaces bit shifting on 1 with the BIT(x) macro. > This was done with coccinelle: > @@ > constant c; > @@ > > -1 << c > +BIT(c) Did you take the time to look at what this Coccinelle script actually did, to see if it actually mak

[PATCH] staging: lustre: Replace a bit shift by a use of BIT.

2017-03-21 Thread Arushi Singhal
This patch replaces bit shifting on 1 with the BIT(x) macro. This was done with coccinelle: @@ constant c; @@ -1 << c +BIT(c) Signed-off-by: Arushi Singhal --- drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c | 2 +- drivers/staging/lustre/lnet/klnds/socklnd/socklnd_cb.c| 8