The subject is too vague and you need a changelog.
On Tue, Aug 01, 2017 at 05:11:29PM +0100, Ashish Kalra wrote:
> +static int inc_txqhead(struct ks_wlan_private *priv)
> +{
> + priv->tx_dev.qhead = (priv->tx_dev.qhead + 1) % TX_DEVICE_BUFF_SIZE;
> + return 0;
Just make these void if no o
On Tue, 2017-08-01 at 17:11 +0100, Ashish Kalra wrote:
> Signed-off-by: Ashish Kalra
Still many issues with this patch submission:
o no commit message
o no version of patch submission in subject line
And other issues below:
> ---
> drivers/staging/ks7010/ks7010_sdio.c | 47
>
Signed-off-by: Ashish Kalra
---
drivers/staging/ks7010/ks7010_sdio.c | 47 +---
1 file changed, 33 insertions(+), 14 deletions(-)
Trivial style changes. There are still "line over 80 characters"
checkpatch.pl warnings, but I think they are best left alone as
break
Hi Ashish,
[auto build test ERROR on staging/staging-testing]
[also build test ERROR on v4.13-rc3 next-20170731]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Ashish-Kalra/staging-ks7010-fix-st
Hi Ashish,
[auto build test ERROR on staging/staging-testing]
[also build test ERROR on v4.13-rc3 next-20170731]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Ashish-Kalra/staging-ks7010-fix-st
On Mon, Jul 31, 2017 at 04:15:21AM +0100, Ashish Kalra wrote:
> Signed-off-by: Ashish Kalra
> ---
I can't accept patches without any changelog comments at all, sorry
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject
Signed-off-by: Ashish Kalra
---
Trivial style changes. There are still "line over 80 characters"
checkpatch.pl warnings, but I think they are best left alone as
breaking these could hurt readability
drivers/staging/ks7010/ks7010_sdio.c | 53 +++-
1 file changed, 4
>From df9062e12930837d5961f2e34ae7eb612820822b Mon Sep 17 00:00:00 2001
From: Ashish Kalra
Date: Mon, 31 Jul 2017 02:28:28 +0100
Subject: [PATCH] Removing Check Errors with checkpatch.pl, Converting from
macro to function call
---
drivers/staging/ks7010/ks7010_sdio.c | 47 +
On Fri, Jun 30, 2017 at 8:39 PM, Mark Rogers wrote:
> Thank you for your feedback. I guess when making this patch I had the
> preferred coding style in mind, but didn't ask myself if making the code
> conform to it would truly improve readability.
>
> I agree with all of your comments. Do you thin
On Fri, Jun 30, 2017 at 11:39:27AM -0700, Mark Rogers wrote:
> Thank you for your feedback. I guess when making this patch I had the
> preferred coding style in mind, but didn't ask myself if making the code
> conform to it would truly improve readability.
>
> I agree with all of your comments. Do
Thank you for your feedback. I guess when making this patch I had the
preferred coding style in mind, but didn't ask myself if making the code
conform to it would truly improve readability.
I agree with all of your comments. Do you think the best course of
action is to create a new patch with this
On Fri, Jun 30, 2017 at 6:52 AM, Mark Rogers wrote:
> Trivial style changes. There are still 3 "line over 80 characters"
> checkpatch.pl warnings, but I think they are best left alone as
> breaking the first two warning lines could hurt readability. The third
> warning is a message that should not
Trivial style changes. There are still 3 "line over 80 characters"
checkpatch.pl warnings, but I think they are best left alone as
breaking the first two warning lines could hurt readability. The third
warning is a message that should not be broken for the sake of grep.
All but one of the changes
13 matches
Mail list logo
