Re: [PATCH] staging: iio: adt7316: Switch to the gpio descriptor interface

2018-10-28 Thread Jonathan Cameron
On Wed, 24 Oct 2018 22:03:54 +0530 Nishad Kamdar wrote: > On Mon, Oct 22, 2018 at 11:22:15PM +0530, Shreeya Patel wrote: > > On Mon, 2018-10-22 at 22:44 +0530, Nishad Kamdar wrote: > > > Use the gpiod interface instead of the deprecated old non-descriptor > > > interface for ldac_pin. > > > >

Re: [PATCH] staging: iio: adt7316: Switch to the gpio descriptor interface

2018-10-24 Thread Nishad Kamdar
On Mon, Oct 22, 2018 at 11:22:15PM +0530, Shreeya Patel wrote: > On Mon, 2018-10-22 at 22:44 +0530, Nishad Kamdar wrote: > > Use the gpiod interface instead of the deprecated old non-descriptor > > interface for ldac_pin. > > > > Signed-off-by: Nishad Kamdar > > --- > > Hi Nishad, > > I have be

Re: [PATCH] staging: iio: adt7316: Switch to the gpio descriptor interface

2018-10-22 Thread Dan Carpenter
On Mon, Oct 22, 2018 at 10:44:22PM +0530, Nishad Kamdar wrote: > - chip->ldac_pin = adt7316_platform_data[1]; > + chip->ldac_pin = devm_gpiod_get(dev, "ldac", GPIOD_OUT_HIGH); > + if (IS_ERR(chip->ldac_pin)) { > + ret = PTR_ERR(chip->ldac_pin); > + dev_err(dev, "

Re: [PATCH] staging: iio: adt7316: Switch to the gpio descriptor interface

2018-10-22 Thread Shreeya Patel
On Mon, 2018-10-22 at 22:44 +0530, Nishad Kamdar wrote: > Use the gpiod interface instead of the deprecated old non-descriptor > interface for ldac_pin. > > Signed-off-by: Nishad Kamdar > --- Hi Nishad, I have been working on implementing device tree bindings for this driver and removing platfo

[PATCH] staging: iio: adt7316: Switch to the gpio descriptor interface

2018-10-22 Thread Nishad Kamdar
Use the gpiod interface instead of the deprecated old non-descriptor interface for ldac_pin. Signed-off-by: Nishad Kamdar --- drivers/staging/iio/addac/adt7316.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/