Re: [PATCH] staging: iio: ad9832: kernel-doc fixes

2021-03-20 Thread Jonathan Cameron
On Mon, 15 Mar 2021 19:07:11 +0530 Mugilraj Dhavachelvan wrote: > Fixes a W=1 warning. > -Added ``:`` to lock parameter in 'ad9832_state' description. > -It's a reference comment so removed /** > > Signed-off-by: Mugilraj Dhavachelvan Great. Thanks for tidying this up. Applied to the togreg

[PATCH] staging: iio: ad9832: kernel-doc fixes

2021-03-15 Thread Mugilraj Dhavachelvan
Fixes a W=1 warning. -Added ``:`` to lock parameter in 'ad9832_state' description. -It's a reference comment so removed /** Signed-off-by: Mugilraj Dhavachelvan --- drivers/staging/iio/frequency/ad9832.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/iio/

Re: [PATCH] staging: iio: ad9832: Add device tree support

2019-05-20 Thread Alexandru Ardelean
On Sun, May 19, 2019 at 8:17 PM Jonathan Cameron wrote: > > On Sat, 18 May 2019 17:48:25 -0300 > João Seckler wrote: > > > Add a of_device_id struct variable and subsequent call to > > MODULE_DEVICE_TABLE macro to support device tree. > > > > Signed-off-by: João Seckler > > Signed-off-by: Anders

Re: [PATCH] staging: iio: ad9832: Add device tree support

2019-05-19 Thread Jonathan Cameron
On Sat, 18 May 2019 17:48:25 -0300 João Seckler wrote: > Add a of_device_id struct variable and subsequent call to > MODULE_DEVICE_TABLE macro to support device tree. > > Signed-off-by: João Seckler > Signed-off-by: Anderson Reis > Co-developed-by: Anderson Reis > Signed-off-by: Andre Tadeu

[PATCH] staging: iio: ad9832: Add device tree support

2019-05-18 Thread João Seckler
Add a of_device_id struct variable and subsequent call to MODULE_DEVICE_TABLE macro to support device tree. Signed-off-by: João Seckler Signed-off-by: Anderson Reis Co-developed-by: Anderson Reis Signed-off-by: Andre Tadeu de Carvalho Co-developed-by: Andre Tadeu de Carvalho --- drivers/sta

Re: [PATCH] staging: iio: ad9832: use 4-digit octal permissions

2017-04-02 Thread Jonathan Cameron
On 30/03/17 10:55, Guru Das Srinagesh wrote: > This fixes the coding style issue of using S_IWUSR in place of 4-digit > octal numbers. > > Issue detected by checkpatch. > > Signed-off-by: Guru Das Srinagesh Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to

[PATCH] staging: iio: ad9832: use 4-digit octal permissions

2017-03-30 Thread Guru Das Srinagesh
This fixes the coding style issue of using S_IWUSR in place of 4-digit octal numbers. Issue detected by checkpatch. Signed-off-by: Guru Das Srinagesh --- drivers/staging/iio/frequency/ad9832.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/sta

Re: [PATCH] staging: iio: ad9832: Move header file content to source file

2017-03-02 Thread Jonathan Cameron
On 01/03/17 18:37, Arushi Singhal wrote: > The contents of the header file are used only by this single > source file. Move content into .c and remove .h. > > Signed-off-by: Arushi Singhal Just noticed that I have another series doing this change waiting for review so probably going to have alrea

Re: [PATCH] staging: iio: ad9832: Move header file content to source file

2017-03-02 Thread Jonathan Cameron
On 01/03/17 18:37, Arushi Singhal wrote: > The contents of the header file are used only by this single > source file. Move content into .c and remove .h. > > Signed-off-by: Arushi Singhal > --- > drivers/staging/iio/frequency/ad9832.c | 100 +- > drivers/staging/iio/freq

[PATCH] staging: iio: ad9832: Move header file content to source file

2017-03-01 Thread Arushi Singhal
The contents of the header file are used only by this single source file. Move content into .c and remove .h. Signed-off-by: Arushi Singhal --- drivers/staging/iio/frequency/ad9832.c | 100 +- drivers/staging/iio/frequency/ad9832.h | 128 -

Re: [PATCH] staging: iio: ad9832:

2016-11-19 Thread Eva Rachel Retuya
On Sat, Nov 19, 2016 at 12:08:34PM +0100, Christophe JAILLET wrote: > Commit a98461d79ba5 ("staging: iio: ad9832: add DVDD regulator") and > commit 43a07e48af44 ("staging: iio: ad9832: clean-up regulator 'reg'") add > some dereference of 'st' which is an un-initialized pointer at this point. > > R

Re: [PATCH] staging: iio: ad9832:

2016-11-19 Thread Jonathan Cameron
On 19/11/16 11:08, Christophe JAILLET wrote: > Commit a98461d79ba5 ("staging: iio: ad9832: add DVDD regulator") and > commit 43a07e48af44 ("staging: iio: ad9832: clean-up regulator 'reg'") add > some dereference of 'st' which is an un-initialized pointer at this point. > > Re-order code and tweak

[PATCH] staging: iio: ad9832:

2016-11-19 Thread Christophe JAILLET
Commit a98461d79ba5 ("staging: iio: ad9832: add DVDD regulator") and commit 43a07e48af44 ("staging: iio: ad9832: clean-up regulator 'reg'") add some dereference of 'st' which is an un-initialized pointer at this point. Re-order code and tweak error handling in order to allocate memory and have 'st

Re: [PATCH] staging: iio: ad9832: allocate data before using

2016-11-08 Thread Eva Rachel Retuya
On Tue, Nov 08, 2016 at 03:00:49PM +0100, Arnd Bergmann wrote: > The regulator changes assigned data to an uninitialized pointer: > > drivers/staging/iio/frequency/ad9832.c: In function 'ad9832_probe': > drivers/staging/iio/frequency/ad9832.c:214:11: error: 'st' may be used > uninitialized in thi

Re: [PATCH] staging: iio: ad9832: allocate data before using

2016-11-08 Thread Jonathan Cameron
On 08/11/16 14:00, Arnd Bergmann wrote: > The regulator changes assigned data to an uninitialized pointer: > > drivers/staging/iio/frequency/ad9832.c: In function 'ad9832_probe': > drivers/staging/iio/frequency/ad9832.c:214:11: error: 'st' may be used > uninitialized in this function [-Werror=may

[PATCH] staging: iio: ad9832: allocate data before using

2016-11-08 Thread Arnd Bergmann
The regulator changes assigned data to an uninitialized pointer: drivers/staging/iio/frequency/ad9832.c: In function 'ad9832_probe': drivers/staging/iio/frequency/ad9832.c:214:11: error: 'st' may be used uninitialized in this function [-Werror=maybe-uninitialized] This moves the allocation of th

Re: [PATCH] staging: iio: ad9832: Use devm_iio_device_register

2014-08-03 Thread Jonathan Cameron
On August 3, 2014 11:45:00 AM GMT+01:00, Julia Lawall wrote: > > >On Sun, 3 Aug 2014, Jonathan Cameron wrote: > >> >> >> On August 3, 2014 10:56:58 AM GMT+01:00, Himangi Saraogi > wrote: >> >This patch introduces the use of devm_iio_device_register and does >away >> >with the unregister in th

Re: [PATCH] staging: iio: ad9832: Use devm_iio_device_register

2014-08-03 Thread Julia Lawall
On Sun, 3 Aug 2014, Jonathan Cameron wrote: > > > On August 3, 2014 10:56:58 AM GMT+01:00, Himangi Saraogi > wrote: > >This patch introduces the use of devm_iio_device_register and does away > >with the unregister in the remove function. > > > And changes the resulting ordering so the regula

Re: [PATCH] staging: iio: ad9832: Use devm_iio_device_register

2014-08-03 Thread Jonathan Cameron
On August 3, 2014 10:56:58 AM GMT+01:00, Himangi Saraogi wrote: >This patch introduces the use of devm_iio_device_register and does away >with the unregister in the remove function. > And changes the resulting ordering so the regulator disable occurs before the user space interface has been r

[PATCH] staging: iio: ad9832: Use devm_iio_device_register

2014-08-03 Thread Himangi Saraogi
This patch introduces the use of devm_iio_device_register and does away with the unregister in the remove function. Signed-off-by: Himangi Saraogi Acked-by: Julia Lawall --- drivers/staging/iio/frequency/ad9832.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/stag