Re: [PATCH] staging: goldfish: Retire a mutable global variable

2018-07-16 Thread Greg KH
On Mon, Jul 16, 2018 at 11:09:48AM -0700, Roman Kiryanov wrote: > I can drop this change. What else do I need to cleanup in > goldfish_audio to proceed with adding other drivers? You need to get the audio developers to review this driver and accept it into their tree. The fact that an audio drive

Re: [PATCH] staging: goldfish: Retire a mutable global variable

2018-07-16 Thread Greg KH
On Fri, Jul 13, 2018 at 02:11:11PM -0700, r...@google.com wrote: > From: Roman Kiryanov > > goldfish_audio_device does not have to be global. > > Signed-off-by: Roman Kiryanov > --- > drivers/staging/goldfish/goldfish_audio.c | 19 +-- > 1 file changed, 13 insertions(+), 6 dele