Re: [PATCH] staging: gdm72xx: fix address space parse warnings

2015-12-11 Thread Okash Khawaja
> On 11 Dec 2015, at 10:52, Dan Carpenter wrote: > >> On Fri, Dec 11, 2015 at 10:33:13AM +, Okash Khawaja wrote: >> Thanks, that's a cleaner approach. Apologies for delayed reply as I'm in >> middle of a house move. I'll send an updated patch soon. > > Someone already fixed it. Thanks. >

Re: [PATCH] staging: gdm72xx: fix address space parse warnings

2015-12-11 Thread Dan Carpenter
On Fri, Dec 11, 2015 at 10:33:13AM +, Okash Khawaja wrote: > Thanks, that's a cleaner approach. Apologies for delayed reply as I'm in > middle of a house move. I'll send an updated patch soon. > Someone already fixed it. Thanks. regards, dan carpenter _

Re: [PATCH] staging: gdm72xx: fix address space parse warnings

2015-12-11 Thread Okash Khawaja
Thanks, that's a cleaner approach. Apologies for delayed reply as I'm in middle of a house move. I'll send an updated patch soon. Okash > On 2 Dec 2015, at 13:17, Dan Carpenter wrote: > > Probably it's better to create a different struct: > > struct udata_s { >unsigned int size; >void

Re: [PATCH] staging: gdm72xx: fix address space parse warnings

2015-12-02 Thread Dan Carpenter
Probably it's better to create a different struct: struct udata_s { unsigned int size; void __user *buf; }; regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/list

[PATCH] staging: gdm72xx: fix address space parse warnings

2015-11-29 Thread Okash Khawaja
copy_to_user() and copy_from_user() functions expect the user space pointers to be marked with __user. Sparse throws following warnings. For copy_to_user(): warning: incorrect type in argument 1 (different address spaces) expected void [noderef] *to got void *buf For copy_from_user(): warning: