Re: [PATCH] staging: fbtft: fix out of bound access

2015-06-04 Thread Sudip Mukherjee
On Thu, Jun 04, 2015 at 03:36:31PM +0300, Dan Carpenter wrote: > On Thu, Jun 04, 2015 at 05:12:01PM +0530, Sudip Mukherjee wrote: > > size of str is 16, but in snprintf the size was mentioned as 128. > > > > Signed-off-by: Sudip Mukherjee > > --- > Good eye. How did you find this? :) not me. cp

Re: [PATCH] staging: fbtft: fix out of bound access

2015-06-04 Thread Dan Carpenter
On Thu, Jun 04, 2015 at 05:12:01PM +0530, Sudip Mukherjee wrote: > size of str is 16, but in snprintf the size was mentioned as 128. > > Signed-off-by: Sudip Mukherjee > --- > drivers/staging/fbtft/fbtft-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/sta

Re: [PATCH] staging: fbtft: fix out of bound access

2015-06-04 Thread Sudip Mukherjee
On Thu, Jun 04, 2015 at 05:12:23AM -0700, Joe Perches wrote: > On Thu, 2015-06-04 at 17:12 +0530, Sudip Mukherjee wrote: > > size of str is 16, but in snprintf the size was mentioned as 128. > [] > > diff --git a/drivers/staging/fbtft/fbtft-core.c > > b/drivers/staging/fbtft/fbtft-core.c > [] > >

Re: [PATCH] staging: fbtft: fix out of bound access

2015-06-04 Thread Joe Perches
On Thu, 2015-06-04 at 17:12 +0530, Sudip Mukherjee wrote: > size of str is 16, but in snprintf the size was mentioned as 128. [] > diff --git a/drivers/staging/fbtft/fbtft-core.c > b/drivers/staging/fbtft/fbtft-core.c [] > @@ -1096,7 +1096,7 @@ static int fbtft_init_display_dt(struct fbtft_par *pa

[PATCH] staging: fbtft: fix out of bound access

2015-06-04 Thread Sudip Mukherjee
size of str is 16, but in snprintf the size was mentioned as 128. Signed-off-by: Sudip Mukherjee --- drivers/staging/fbtft/fbtft-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c index ce64521..0af8